<div dir="ltr"><div><span style="color:rgb(0,0,0);font-family:arial;font-size:14px">Patches 1 to 6 of this series are pushed.</span><br></div><div><span class="gmail-im" style=""><font color="#000000" face="arial"><span style="font-size:14px"><br></span></font></span></div><div><span class="gmail-im" style=""><font color="#000000" face="arial"><span style="font-size:14px"><br class="gmail-Apple-interchange-newline"></span></font></span><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><table border="0" cellpadding="0" cellspacing="0" style="color:rgb(0,0,0);font-family:"Times New Roman";font-size:medium"><tbody><tr><td style="vertical-align:top;padding-left:10px"><p style="margin:0px;line-height:20px"><b style="font-family:Arial,sans-serif"><font color="#444444">Karam Singh</font></b></p><p style="margin:0px;line-height:20px"><b style="font-family:Arial,sans-serif"><font color="#444444">Ph.D. IIT Guwahati</font></b></p><p style="margin:0px;line-height:20px"><b style="color:rgb(102,102,102);font-family:Arial,sans-serif;font-size:x-small">Senior Software (Video Coding) Engineer  </b></p><p style="margin:0px;line-height:20px"><span style="font-size:x-small;font-family:Arial,sans-serif;color:rgb(88,88,88)">Mobile: +91 8011279030</span></p><p style="margin:0px;line-height:16px"><span style="color:rgb(36,36,36)"><span style="font-family:Arial,Helvetica,sans-serif"><span style="font-size:11px"><span style="line-height:16px"><span style="color:rgb(88,88,88)"><span style="font-family:Arial,sans-serif"><span style="font-size:13.3333px"><span style="font-size:10px">Block 9A, 6th floor, </span></span></span></span><span style="color:rgb(88,88,88)"><span style="font-family:Arial,sans-serif"><span style="font-size:x-small">DLF Cyber City</span></span></span></span></span></span></span><br></p><p style="margin:0px;line-height:16px"><span style="color:rgb(36,36,36)"><span style="font-family:Arial,Helvetica,sans-serif"><span style="font-size:11px"><span style="color:rgb(88,88,88)"><span style="font-family:Arial,sans-serif"><span style="font-size:x-small">Manapakkam, Chennai 600 089</span></span></span></span></span></span><br></p></td></tr><tr><td valign="top" align="center" style="padding-right:10px"><img src="https://ci3.googleusercontent.com/mail-sig/AIorK4yP_T0tZnWYAbKHbRi0Pt8l8koPJBmOijhmBRMYVotNrmftxEnTmN93Ac-sC2XTKbHwXR-SV97SisS9"><br></td><td valign="top" style="padding:0px 0px 0px 10px"></td></tr></tbody></table></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 23, 2024 at 7:42 AM chen <<a href="mailto:chenm003@163.com">chenm003@163.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="line-height:1.7;color:rgb(0,0,0);font-size:14px;font-family:Arial"><div id="m_4067291984098992298spnEditorContent"><p style="margin:0px">Hi <span style="font-family:arial;white-space:pre-wrap">Hari,</span></p><p style="margin:0px"><span style="font-family:arial;white-space:pre-wrap"><br></span></p><p style="margin:0px"><span style="font-family:arial;white-space:pre-wrap">The new patches looks good for me now, thank you for your patches.</span></p><p style="margin:0px"><span style="font-family:arial;white-space:pre-wrap"><br></span></p><p style="margin:0px"><span style="font-family:arial;white-space:pre-wrap">Regards,</span></p><p style="margin:0px"><span style="font-family:arial;white-space:pre-wrap">Chen</span></p></div><pre>At 2024-05-23 03:09:26, "Hari Limaye" <<a href="mailto:hari.limaye@arm.com" target="_blank">hari.limaye@arm.com</a>> wrote:
>Hi Chen,
>
>Thank you for reviewing the patches.
>
>>In signOf_neon
>>>+ // signOf(a - b) = -(a > b) | (b > a)
>>comments is not clear, suggest
>>-(a > b ? -1 : 0) | ( a < b)
>
>I have posted updated versions of patches 3, 4, 6 to make these comments more clear with respect to the possible outputs of Neon comparison instructions.
>
>>In saoCuStatsBO_neon
>>It is memory bandwidth optimize only, interval memory access strong depends on CPU pipeline design and >compiler, it is not generic, not sure how about on other kind of CPUs.
>
>Yes it is primarily a memory bandwidth optimisation - we have tested with recent GCC and Clang on a range of Neoverse CPUs and find it to be faster than the C implementation.
>
>>In saoCuStatsE*_neon
>>No comments, it looks vmulq_s16+vmlaq_s16 reduce 1 instruction than vandq_s16+vandq_s16+vaddq_s16 or tbl/tbx, >it mostly faster on modern CPUs
>
>Yes, we found that this instruction sequence was faster than the alternatives, for the Neon implementation.
>
>Many thanks,
>
>Hari
</pre></div>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div>