<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
p.qt-msonormal1, li.qt-msonormal1, div.qt-msonormal1
{mso-style-name:qt-msonormal1;
margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
span.size
{mso-style-name:size;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Thank you for clarifying.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">I will post an updated patch that guards the addition of `-Werror` behind a CMake option that is switched off by default, if that is not objectionable?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Many thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Hari<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="color:black">From:
</span></b><span style="color:black">x265-devel <x265-devel-bounces@videolan.org> on behalf of Jean-Baptiste Kempf <jb@videolan.org><br>
<b>Date: </b>Tuesday, 20 August 2024 at 20:01<br>
<b>To: </b>Hari Limaye <Hari.Limaye@arm.com>, Development for x265 <x265-devel@videolan.org><br>
<b>Cc: </b>nd <nd@arm.com><br>
<b>Subject: </b>Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal">Using Werror is always a bad idea, since you can’t know all the compilers configurations, but mostly, you cannot know how future compilers will behave.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">So use Werror in your builds, make CI use Werror if you want but never put that in a package.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">On Tue, 20 Aug 2024, at 20:12, Hari Limaye wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt" id="qt">
<div>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt">Hi JB,</span></span><o:p></o:p></p>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt"> </span></span><o:p></o:p></p>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt">Could you elaborate on why you think this is a bad idea?</span></span><o:p></o:p></p>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt"> </span></span><o:p></o:p></p>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt">Many thanks,</span></span><o:p></o:p></p>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt">Hari</span></span><o:p></o:p></p>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt"> </span></span><o:p></o:p></p>
<div id="qt-mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm;border-right-color:currentcolor;border-bottom-color:currentcolor;border-left-color:currentcolor">
<p class="qt-msonormal1" style="margin-bottom:12.0pt"><b><span style="color:black">From:
</span></b><span style="color:black">x265-devel <x265-devel-bounces@videolan.org> on behalf of Jean-Baptiste Kempf <jb@videolan.org><br>
<b>Date: </b>Tuesday, 20 August 2024 at 18:52<br>
<b>To: </b>x265-devel@videolan.org <x265-devel@videolan.org><br>
<b>Subject: </b>Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror</span><o:p></o:p></p>
</div>
<div>
<p class="qt-msonormal1"><span class="size"><span style="font-size:11.0pt">This is a bad idea. Don’t do that, except in your debut builds.</span></span><span style="font-size:11.0pt"><br>
<br>
<span class="size">On Tue, 20 Aug 2024, at 19:42, Hari Limaye wrote:</span><br>
<span class="size">> Add -Werror when compiling AArch64 intrinsics files to ensure that the</span><br>
<span class="size">> code is free from compiler warnings.</span><br>
<span class="size">> ---</span><br>
<span class="size">> source/common/CMakeLists.txt | 1 +</span><br>
<span class="size">> 1 file changed, 1 insertion(+)</span><br>
<span class="size">></span><br>
<span class="size">> diff --git a/source/common/CMakeLists.txt b/source/common/CMakeLists.txt</span><br>
<span class="size">> index 47b23bcd2..6b4b25618 100644</span><br>
<span class="size">> --- a/source/common/CMakeLists.txt</span><br>
<span class="size">> +++ b/source/common/CMakeLists.txt</span><br>
<span class="size">> @@ -136,6 +136,7 @@ if(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))</span><br>
<span class="size">> endif()</span><br>
<span class="size">> </span><br>
<span class="size">> source_group(Assembly FILES ${ASM_PRIMITIVES})</span><br>
<span class="size">> + set_source_files_properties(${ASM_PRIMITIVES} PROPERTIES
</span><br>
<span class="size">> COMPILE_FLAGS -Werror)</span><br>
<span class="size">> endif(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))</span><br>
<span class="size">> </span><br>
<span class="size">> if(POWER)</span><br>
<span class="size">> -- </span><br>
<span class="size">> 2.42.1</span><br>
<span class="size">></span><br>
<span class="size">></span><br>
<span class="size">> _______________________________________________</span><br>
<span class="size">> x265-devel mailing list</span><br>
<span class="size">> x265-devel@videolan.org</span><br>
<span class="size">> <a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a></span><br>
<span class="size">></span><br>
<span class="size">> Attachments:</span><br>
<span class="size">> * 0003-AArch64-Compile-intrinsics-files-with-Werror.patch</span><br>
<br>
<span class="size">-- </span><br>
<span class="size">Jean-Baptiste Kempf - President</span><br>
<span class="size">+33 672 704 734</span><br>
<span class="size"><a href="https://jbkempf.com/">https://jbkempf.com/</a></span><br>
<span class="size">_______________________________________________</span><br>
<span class="size">x265-devel mailing list</span><br>
<span class="size">x265-devel@videolan.org</span><br>
<span class="size"><a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a></span></span><o:p></o:p></p>
</div>
</div>
</div>
</div>
<div>
<p class="MsoNormal">_______________________________________________<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">x265-devel mailing list<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div id="sig60240713">
<div>
<p class="MsoNormal">-- <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Jean-Baptiste Kempf - President<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+33 672 704 734<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="https://jbkempf.com/">https://jbkempf.com/</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>