<!DOCTYPE html><html><head><title></title><style type="text/css">#qt p.qt-MsoNormal{margin-top:0cm;margin-right:0cm;margin-bottom:0cm;margin-left:0cm;font-size:12pt;font-family:"Aptos", sans-serif;}
#qt a:link{color:blue;text-decoration-line:underline;text-decoration-style:solid;text-decoration-color:currentcolor;text-decoration-thickness:auto;}
#qt p.qt-qt-msonormal1{margin-top:0cm;margin-right:0cm;margin-bottom:0cm;margin-left:0cm;font-size:12pt;font-family:"Aptos", sans-serif;}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Sure.<br></div><div><br></div><div>On Tue, 20 Aug 2024, at 21:04, Hari Limaye wrote:<br></div><blockquote type="cite" id="qt" style="overflow-wrap:break-word;"><div class="qt-WordSection1"><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Thank you for clarifying.</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;"> </span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">I will post an updated patch that guards the addition of `-Werror` behind a CMake option that is switched off by default, if that is not objectionable?</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;"> </span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Many thanks,</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Hari</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;"> </span><br></p><div id="qt-mail-editor-reference-message-container"><div><div style="border-right-width:medium;border-right-style:none;border-right-color:currentcolor;border-bottom-width:medium;border-bottom-style:none;border-bottom-color:currentcolor;border-left-width:medium;border-left-style:none;border-left-color:currentcolor;border-image-outset:0;border-image-repeat:stretch;border-image-slice:100%;border-image-source:none;border-image-width:1;border-top-width:1pt;border-top-style:solid;border-top-color:rgb(181, 196, 223);padding-top:3pt;padding-right:0cm;padding-bottom:0cm;padding-left:0cm;"><p class="qt-MsoNormal" style="margin-bottom:12pt;"><b><span style="color:black;">From: </span></b><span style="color:black;">x265-devel <x265-devel-bounces@videolan.org> on behalf of Jean-Baptiste Kempf <jb@videolan.org><br> <b>Date: </b>Tuesday, 20 August 2024 at 20:01<br> <b>To: </b>Hari Limaye <Hari.Limaye@arm.com>, Development for x265 <x265-devel@videolan.org><br> <b>Cc: </b>nd <nd@arm.com><br> <b>Subject: </b>Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror</span></p></div><div><p class="qt-MsoNormal">Using Werror is always a bad idea, since you can’t know all the compilers configurations, but mostly, you cannot know how future compilers will behave.<br></p></div><div><p class="qt-MsoNormal">So use Werror in your builds, make CI use Werror if you want but never put that in a package.<br></p></div><div><p class="qt-MsoNormal"> <br></p></div><div><p class="qt-MsoNormal">On Tue, 20 Aug 2024, at 20:12, Hari Limaye wrote:<br></p></div><blockquote style="margin-top:5pt;margin-bottom:5pt;" id="qt-qt"><div><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;">Hi JB,</span></span><br></p><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;"> </span></span><br></p><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;">Could you elaborate on why you think this is a bad idea?</span></span><br></p><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;"> </span></span><br></p><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;">Many thanks,</span></span><br></p><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;">Hari</span></span><br></p><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;"> </span></span><br></p><div id="qt-qt-mail-editor-reference-message-container"><div><div style="border-right-width:medium;border-right-style:none;border-bottom-width:medium;border-bottom-style:none;border-left-width:medium;border-left-style:none;border-image-outset:0;border-image-repeat:stretch;border-image-slice:100%;border-image-source:none;border-image-width:1;border-top-width:1pt;border-top-style:solid;border-top-color:rgb(181, 196, 223);padding-top:3pt;padding-right:0cm;padding-bottom:0cm;padding-left:0cm;border-right-color:currentcolor;border-bottom-color:currentcolor;border-left-color:currentcolor;"><p class="qt-qt-msonormal1" style="margin-bottom:12pt;"><b><span style="color:black;">From: </span></b><span style="color:black;">x265-devel <x265-devel-bounces@videolan.org> on behalf of Jean-Baptiste Kempf <jb@videolan.org><br> <b>Date: </b>Tuesday, 20 August 2024 at 18:52<br> <b>To: </b>x265-devel@videolan.org <x265-devel@videolan.org><br> <b>Subject: </b>Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror</span></p></div><div><p class="qt-qt-msonormal1"><span class="qt-size"><span class="size" style="font-size:11pt;">This is a bad idea. Don’t do that, except in your debut builds.</span></span><span class="size" style="font-size:11pt;"><br> <br> <span class="qt-size">On Tue, 20 Aug 2024, at 19:42, Hari Limaye wrote:</span><br> <span class="qt-size">> Add -Werror when compiling AArch64 intrinsics files to ensure that the</span><br> <span class="qt-size">> code is free from compiler warnings.</span><br> <span class="qt-size">> ---</span><br> <span class="qt-size">> source/common/CMakeLists.txt | 1 +</span><br> <span class="qt-size">> 1 file changed, 1 insertion(+)</span><br> <span class="qt-size">></span><br> <span class="qt-size">> diff --git a/source/common/CMakeLists.txt b/source/common/CMakeLists.txt</span><br> <span class="qt-size">> index 47b23bcd2..6b4b25618 100644</span><br> <span class="qt-size">> --- a/source/common/CMakeLists.txt</span><br> <span class="qt-size">> +++ b/source/common/CMakeLists.txt</span><br> <span class="qt-size">> @@ -136,6 +136,7 @@ if(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))</span><br> <span class="qt-size">> endif()</span><br> <span class="qt-size">> </span><br> <span class="qt-size">> source_group(Assembly FILES ${ASM_PRIMITIVES})</span><br> <span class="qt-size">> + set_source_files_properties(${ASM_PRIMITIVES} PROPERTIES </span><br> <span class="qt-size">> COMPILE_FLAGS -Werror)</span><br> <span class="qt-size">> endif(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))</span><br> <span class="qt-size">> </span><br> <span class="qt-size">> if(POWER)</span><br> <span class="qt-size">> -- </span><br> <span class="qt-size">> 2.42.1</span><br> <span class="qt-size">></span><br> <span class="qt-size">></span><br> <span class="qt-size">> _______________________________________________</span><br> <span class="qt-size">> x265-devel mailing list</span><br> <span class="qt-size">> x265-devel@videolan.org</span><br> <span class="qt-size">> <a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a></span><br> <span class="qt-size">></span><br> <span class="qt-size">> Attachments:</span><br> <span class="qt-size">> * 0003-AArch64-Compile-intrinsics-files-with-Werror.patch</span><br> <br> <span class="qt-size">-- </span><br> <span class="qt-size">Jean-Baptiste Kempf - President</span><br> <span class="qt-size">+33 672 704 734</span><br> <span class="qt-size"><a href="https://jbkempf.com/">https://jbkempf.com/</a></span><br> <span class="qt-size">_______________________________________________</span><br> <span class="qt-size">x265-devel mailing list</span><br> <span class="qt-size">x265-devel@videolan.org</span><br> <span class="qt-size"><a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a></span></span></p></div></div></div></div><div><p class="qt-MsoNormal">_______________________________________________<br></p></div><div><p class="qt-MsoNormal">x265-devel mailing list<br></p></div><div><p class="qt-MsoNormal"><a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br></p></div><div><p class="qt-MsoNormal"><a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><br></p></div><div><p class="qt-MsoNormal"> <br></p></div></blockquote><div><p class="qt-MsoNormal"> <br></p></div><div id="qt-sig60240713"><div><p class="qt-MsoNormal">-- <br></p></div><div><p class="qt-MsoNormal">Jean-Baptiste Kempf - President<br></p></div><div><p class="qt-MsoNormal">+33 672 704 734<br></p></div><div><p class="qt-MsoNormal"><a href="https://jbkempf.com/">https://jbkempf.com/</a><br></p></div><div><p class="qt-MsoNormal"> <br></p></div></div><div><p class="qt-MsoNormal"> <br></p></div></div></div></div><div>_______________________________________________<br></div><div>x265-devel mailing list<br></div><div><a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br></div><div><a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><br></div><div><br></div></blockquote><div><br></div><div id="sig60240713"><div class="signature">-- </div><div class="signature">Jean-Baptiste Kempf - President</div><div class="signature">+33 672 704 734</div><div class="signature"><a href="https://jbkempf.com/">https://jbkempf.com/</a></div><div class="signature"><br></div></div><div><br></div></body></html>