<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Hi JB,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Could you elaborate on why you think this is a bad idea?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Many thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Hari<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="color:black">From:
</span></b><span style="color:black">x265-devel <x265-devel-bounces@videolan.org> on behalf of Jean-Baptiste Kempf <jb@videolan.org><br>
<b>Date: </b>Tuesday, 20 August 2024 at 18:52<br>
<b>To: </b>x265-devel@videolan.org <x265-devel@videolan.org><br>
<b>Subject: </b>Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">This is a bad idea. Don’t do that, except in your debut builds.<br>
<br>
On Tue, 20 Aug 2024, at 19:42, Hari Limaye wrote:<br>
> Add -Werror when compiling AArch64 intrinsics files to ensure that the<br>
> code is free from compiler warnings.<br>
> ---<br>
> source/common/CMakeLists.txt | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/source/common/CMakeLists.txt b/source/common/CMakeLists.txt<br>
> index 47b23bcd2..6b4b25618 100644<br>
> --- a/source/common/CMakeLists.txt<br>
> +++ b/source/common/CMakeLists.txt<br>
> @@ -136,6 +136,7 @@ if(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))<br>
> endif()<br>
> <br>
> source_group(Assembly FILES ${ASM_PRIMITIVES})<br>
> + set_source_files_properties(${ASM_PRIMITIVES} PROPERTIES <br>
> COMPILE_FLAGS -Werror)<br>
> endif(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))<br>
> <br>
> if(POWER)<br>
> -- <br>
> 2.42.1<br>
><br>
><br>
> _______________________________________________<br>
> x265-devel mailing list<br>
> x265-devel@videolan.org<br>
> <a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><br>
><br>
> Attachments:<br>
> * 0003-AArch64-Compile-intrinsics-files-with-Werror.patch<br>
<br>
-- <br>
Jean-Baptiste Kempf - President<br>
+33 672 704 734<br>
<a href="https://jbkempf.com/">https://jbkempf.com/</a><br>
_______________________________________________<br>
x265-devel mailing list<br>
x265-devel@videolan.org<br>
<a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>