<!DOCTYPE html><html><head><title></title><style type="text/css">#qt p.qt-MsoNormal{margin-top:0cm;margin-right:0cm;margin-bottom:0cm;margin-left:0cm;font-size:12pt;font-family:Aptos, sans-serif;}
#qt a:link{color:blue;text-decoration-line:underline;}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Using Werror is always a bad idea, since you can’t know all the compilers configurations, but mostly, you cannot know how future compilers will behave.<br></div><div>So use Werror in your builds, make CI use Werror if you want but never put that in a package.</div><div><br></div><div>On Tue, 20 Aug 2024, at 20:12, Hari Limaye wrote:<br></div><blockquote type="cite" id="qt" style="overflow-wrap:break-word;"><div class="qt-WordSection1"><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Hi JB,</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;"> </span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Could you elaborate on why you think this is a bad idea?</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;"> </span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Many thanks,</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">Hari</span><br></p><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;"> </span><br></p><div id="qt-mail-editor-reference-message-container"><div><div style="border-right-width:medium;border-bottom-width:medium;border-left-width:medium;border-right-style:none;border-bottom-style:none;border-left-style:none;border-right-color:currentcolor;border-bottom-color:currentcolor;border-left-color:currentcolor;border-image-source:none;border-image-slice:100%;border-image-width:1;border-image-outset:0;border-image-repeat:stretch;border-top-width:1pt;border-top-style:solid;border-top-color:rgb(181, 196, 223);padding-top:3pt;padding-right:0cm;padding-bottom:0cm;padding-left:0cm;"><p class="qt-MsoNormal" style="margin-bottom:12pt;"><b><span style="color:black;">From: </span></b><span style="color:black;">x265-devel <x265-devel-bounces@videolan.org> on behalf of Jean-Baptiste Kempf <jb@videolan.org><br> <b>Date: </b>Tuesday, 20 August 2024 at 18:52<br> <b>To: </b>x265-devel@videolan.org <x265-devel@videolan.org><br> <b>Subject: </b>Re: [x265] [PATCH 3/3] AArch64: Compile intrinsics files with -Werror</span></p></div><div><p class="qt-MsoNormal"><span class="size" style="font-size:11pt;">This is a bad idea. Don’t do that, except in your debut builds.<br> <br> On Tue, 20 Aug 2024, at 19:42, Hari Limaye wrote:<br> > Add -Werror when compiling AArch64 intrinsics files to ensure that the<br> > code is free from compiler warnings.<br> > ---<br> > source/common/CMakeLists.txt | 1 +<br> > 1 file changed, 1 insertion(+)<br> ><br> > diff --git a/source/common/CMakeLists.txt b/source/common/CMakeLists.txt<br> > index 47b23bcd2..6b4b25618 100644<br> > --- a/source/common/CMakeLists.txt<br> > +++ b/source/common/CMakeLists.txt<br> > @@ -136,6 +136,7 @@ if(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))<br> > endif()<br> > <br> > source_group(Assembly FILES ${ASM_PRIMITIVES})<br> > + set_source_files_properties(${ASM_PRIMITIVES} PROPERTIES <br> > COMPILE_FLAGS -Werror)<br> > endif(ENABLE_ASSEMBLY AND (ARM64 OR CROSS_COMPILE_ARM64))<br> > <br> > if(POWER)<br> > -- <br> > 2.42.1<br> ><br> ><br> > _______________________________________________<br> > x265-devel mailing list<br> > x265-devel@videolan.org<br> > <a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><br> ><br> > Attachments:<br> > * 0003-AArch64-Compile-intrinsics-files-with-Werror.patch<br> <br> -- <br> Jean-Baptiste Kempf - President<br> +33 672 704 734<br> <a href="https://jbkempf.com/">https://jbkempf.com/</a><br> _______________________________________________<br> x265-devel mailing list<br> x265-devel@videolan.org<br> <a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a></span></p></div></div></div></div><div>_______________________________________________<br></div><div>x265-devel mailing list<br></div><div><a href="mailto:x265-devel@videolan.org">x265-devel@videolan.org</a><br></div><div><a href="https://mailman.videolan.org/listinfo/x265-devel">https://mailman.videolan.org/listinfo/x265-devel</a><br></div><div><br></div></blockquote><div><br></div><div id="sig60240713"><div class="signature">-- </div><div class="signature">Jean-Baptiste Kempf - President</div><div class="signature">+33 672 704 734</div><div class="signature"><a href="https://jbkempf.com/">https://jbkempf.com/</a></div><div class="signature"><br></div></div><div><br></div></body></html>