<div dir="ltr">This patch has been pushed to the master branch. <br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><b>__________________________</b></div><div><b>Karam Singh</b></div><div><b>Ph.D. IIT Guwahati</b></div><div><font size="1">Senior Software (Video Coding) Engineer </font></div><div><font size="1">Mobile: +91 8011279030</font></div><div><font size="1">Block 9A, 6th floor, DLF Cyber City</font></div><div><font size="1">Manapakkam, Chennai 600 089</font></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 5, 2024 at 5:50 AM chen <<a href="mailto:chenm003@163.com">chenm003@163.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="line-height:1.7;color:rgb(0,0,0);font-size:14px;font-family:Arial"><div id="m_-2311780272403928246spnEditorContent"><p style="margin:0px">Hi Hari,</p><p style="margin:0px"><br></p><p style="margin:0px">The new version looks good, thank you.</p><p style="margin:0px"><br></p><p style="margin:0px">Regards,</p><p style="margin:0px">Chen</p></div><pre>At 2024-08-01 17:29:01, "Hari Limaye" <<a href="mailto:hari.limaye@arm.com" target="_blank">hari.limaye@arm.com</a>> wrote:
>Hi Chen,
>
>Thank you for reviewing the SAD patches.
>
>I am putting this patch up to handle emitting warnings for platforms
>where compile time feature detection is not implemented - as this is
>currently true for all the existing find_package(*) scripts for AArch64
>feature detection.
>
>Note: this patch is based on the `AArch64 SAD/SADxN Optimisations`
>stack.
>
>Many thanks,
>Hari
>
>---
>As compile time feature detection for AArch64 platforms is currently
>only supported on Linux and Darwin platforms, emit a warning message
>when compiling for any other platform.
>---
> source/CMakeLists.txt | 41 ++++++++++++++++++++++++-----------------
> 1 file changed, 24 insertions(+), 17 deletions(-)
>
>diff --git a/source/CMakeLists.txt b/source/CMakeLists.txt
>index 8288fd234..55e4926c6 100755
>--- a/source/CMakeLists.txt
>+++ b/source/CMakeLists.txt
>@@ -265,25 +265,32 @@ if(GCC)
> set(CPU_HAS_NEON 1)
> add_definitions(-DX265_ARCH_ARM64=1 -DHAVE_NEON=1)
>
>- # Handle cross-compilation options.
>- if(CROSS_COMPILE_NEON_DOTPROD)
>- set(CPU_HAS_NEON_DOTPROD 1)
>- endif()
>- if(CROSS_COMPILE_SVE)
>- set(CPU_HAS_SVE 1)
>- # We impose the constraint that SVE implies Neon DotProd.
>- set(CPU_HAS_NEON_DOTPROD 1)
>- endif()
>- if(CROSS_COMPILE_SVE2)
>- set(CPU_HAS_SVE2 1)
>- # SVE2 implies SVE and Neon DotProd.
>- set(CPU_HAS_SVE 1)
>- set(CPU_HAS_NEON_DOTPROD 1)
>+ if(CROSS_COMPILE_ARM64)
>+ # Handle cross-compilation options.
>+ if(CROSS_COMPILE_NEON_DOTPROD)
>+ set(CPU_HAS_NEON_DOTPROD 1)
>+ endif()
>+ if(CROSS_COMPILE_SVE)
>+ set(CPU_HAS_SVE 1)
>+ # We impose the constraint that SVE implies Neon DotProd.
>+ set(CPU_HAS_NEON_DOTPROD 1)
>+ endif()
>+ if(CROSS_COMPILE_SVE2)
>+ set(CPU_HAS_SVE2 1)
>+ # SVE2 implies SVE and Neon DotProd.
>+ set(CPU_HAS_SVE 1)
>+ set(CPU_HAS_NEON_DOTPROD 1)
>+ endif()
>+ else()
>+ if(CMAKE_SYSTEM_NAME MATCHES "Linux|Darwin")
>+ find_package(NEON_DOTPROD)
>+ find_package(SVE)
>+ find_package(SVE2)
>+ else()
>+ message(STATUS "Compile time feature detection unsupported on this platform")
>+ endif()
> endif()
>
>- find_package(NEON_DOTPROD)
>- find_package(SVE)
>- find_package(SVE2)
> if(CPU_HAS_NEON_DOTPROD)
> # Neon DotProd is mandatory from Armv8.4.
> message(STATUS "Found Neon DotProd")
>--
>2.42.1
>
</pre></div>_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div>