<div dir="ltr"><div dir="ltr">This patch has been pushed to the master branch. <br clear="all"><div><div dir="ltr" class="gmail_signature"><div dir="ltr"></div></div></div><div><div dir="ltr" class="gmail_signature"><div dir="ltr"></div></div></div><div><div dir="ltr" class="gmail_signature"><div dir="ltr"></div></div></div><div><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><b>__________________________</b></div><div><b>Karam Singh</b></div><div><b>Ph.D. IIT Guwahati</b></div><div><font size="1">Senior Software (Video Coding) Engineer </font></div><div><font size="1">Mobile: +91 8011279030</font></div><div><font size="1">Block 9A, 6th floor, DLF Cyber City</font></div><div><font size="1">Manapakkam, Chennai 600 089</font></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Sep 30, 2024 at 1:58 PM Kirithika Kalirathnam <<a href="mailto:kirithika@multicorewareinc.com">kirithika@multicorewareinc.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">From 7d661649d87789e587f80307e6574e6b08003bf1 Mon Sep 17 00:00:00 2001<br>From: Kirithika <<a href="mailto:kirithika@multicorewareinc.com" target="_blank">kirithika@multicorewareinc.com</a>><br>Date: Mon, 30 Sep 2024 13:20:18 +0530<br>Subject: [PATCH] Fix CLI parsing for MV-HEVC Encode<br><br>This commit does the following:<br>1.For encodes with --multiview-config enabled, it allows only one extra argument in the CLI that would be treated as --output(output bitstream)<br>2.Update docs<br>---<br> doc/reST/cli.rst | 7 +++++--<br> source/x265cli.cpp | 7 ++++++-<br> 2 files changed, 11 insertions(+), 3 deletions(-)<br><br>diff --git a/doc/reST/cli.rst b/doc/reST/cli.rst<br>index 95cb37f20..c00240187 100755<br>--- a/doc/reST/cli.rst<br>+++ b/doc/reST/cli.rst<br>@@ -25,7 +25,9 @@ there are two extra arguments, the second is treated as the output<br> bitstream filename, making :option:`--output` also optional if the input<br> filename was implied. This makes :command:`x265 in.y4m out.hevc` a valid<br> command line. If there are more than two extra arguments, the CLI will<br>-consider this an error and abort.<br>+consider this an error and abort.For Multiview encodes i.e encodes with<br>+:option:`--multiview-config` , only one extra command line argument is <br>+allowed and the CLI will treat it as the output filename.<br> <br> Generally, when an option expects a string value from a list of strings<br> the user may specify the integer ordinal of the value they desire. ie:<br>@@ -2930,7 +2932,8 @@ Multiview Encode Options<br> <br> <br> Other input parameters such as input-csp/input-depth/input-res/fps must be configured through<br>- normal CLI and is expected to be same for all views.<br>+ normal CLI and is expected to be same for all views.The input filename(s):option:`--input` alone will be inferred<br>+ from the config file.<br> <br> **CLI_ONLY**<br> <br>diff --git a/source/x265cli.cpp b/source/x265cli.cpp<br>index 40eac4c8d..efd9b2fe0 100755<br>--- a/source/x265cli.cpp<br>+++ b/source/x265cli.cpp<br>@@ -806,11 +806,16 @@ namespace X265_NS {<br> }<br> }<br> <br>- if (param->numViews < 2)<br>+#if !ENABLE_MULTIVIEW<br>+ if (optind < argc && !(*inputfn[0]))<br>+ strncpy(inputfn[0], argv[optind++], 1024);<br>+#else<br>+ if (!this->multiViewConfig)<br> {<br> if (optind < argc && !(*inputfn[0]))<br> strncpy(inputfn[0], argv[optind++], 1024);<br> }<br>+#endif<br> if (optind < argc && !outputfn)<br> outputfn = argv[optind++];<br> if (optind < argc)<br>-- <br>2.28.0.windows.1<br><br><div><div dir="ltr" class="gmail_signature"><div dir="ltr"><i>Thanks,</i><div><i>Kirithika</i></div></div></div></div></div>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div>