<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">Hi,<br>Thanks for the suggestions<br>Min Chen has made these changes in the next patch.<br><br>Thanks,<br>Pavan Tarun</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Nov 10, 2024 at 11:10 PM Andrey Semashev <<a href="mailto:andrey.semashev@gmail.com">andrey.semashev@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 11/10/24 13:50, Jean-Baptiste Kempf wrote:<br>
> On Sun, 10 Nov 2024, at 06:39, Pavan Tarun Chakka Venkata wrote:<br>
> <br>
>>          if (m_latestParam->scalingLists != m_param->scalingLists)<br>
>>              free((char*)m_latestParam->scalingLists);<br>
>> +        if (m_latestParam->numaPools != m_param->numaPools)<br>
>> +            free((char*)m_latestParam->numaPools);<br>
> <br>
> As above.<br>
<br>
These two are not null checks.<br>
<br>
The type casts are superfluous, though.<br>
<br>
_______________________________________________<br>
x265-devel mailing list<br>
<a href="mailto:x265-devel@videolan.org" target="_blank">x265-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/x265-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/x265-devel</a><br>
</blockquote></div>