<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<span style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">From 86ad3c346a184c11b001cb219ff950617efb76d9 Mon Sep 17 00:00:00 2001</span>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
From: PavanTarun <pavan.tarun@multicorewareinc.com></div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Date: Wed, 26 Feb 2025 14:50:38 +0530</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Subject: [PATCH] Fix Testbench Warnings</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
---</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
source/test/pixelharness.cpp | 22 ++++++++--------------</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
1 file changed, 8 insertions(+), 14 deletions(-)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
diff --git a/source/test/pixelharness.cpp b/source/test/pixelharness.cpp</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
index abb9b90e1..10f66cda1 100644</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--- a/source/test/pixelharness.cpp</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+++ b/source/test/pixelharness.cpp</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
@@ -2160,13 +2160,12 @@ bool PixelHarness::check_pelFilterLumaStrong_V(pelFilterLumaStrong_t ref, pelFil</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
bool PixelHarness::check_pelFilterChroma_H(pelFilterChroma_t ref, pelFilterChroma_t opt)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
{</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
intptr_t srcStep = 1, offset = 64;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- int32_t maskP, maskQ, tc;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
intptr_t j = 0;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
const int NUM_MASKS = 3;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
pixel pixel_test_buff1[TEST_CASES][BUFFSIZE];</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
for (int i = 0; i < TEST_CASES; i++)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- memcpy(pixel_test_buff1[i], pixel_test_buff[i], sizeof(pixel)* BUFFSIZE);</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ memcpy(pixel_test_buff1[i], pixel_test_buff[i], sizeof(pixel) * BUFFSIZE);</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int32_t masks[NUM_MASKS][2] = {{-1, -1}, {-1, 0}, {0, -1}};</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
@@ -2174,11 +2173,9 @@ bool PixelHarness::check_pelFilterChroma_H(pelFilterChroma_t ref, pelFilterChrom</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
{</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int32_t maskP = masks[i][0];</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int32_t maskQ = masks[i][1];</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
-</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- for (int i = 0; i < ITERS; i++)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ for (int k = 0; k < ITERS; k++)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
{</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- tc = rand() % PIXEL_MAX;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
-</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ int32_t tc = rand() % PIXEL_MAX;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int index = rand() % 3;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
ref(pixel_test_buff[index] + 2 * offset + j, srcStep, offset, tc, maskP, maskQ);</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
@@ -2187,7 +2184,7 @@ bool PixelHarness::check_pelFilterChroma_H(pelFilterChroma_t ref, pelFilterChrom</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
if (memcmp(pixel_test_buff[index], pixel_test_buff1[index], sizeof(pixel) * BUFFSIZE))</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
return false;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- reportfail()</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ reportfail();</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
j += INCR;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
}</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
}</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
@@ -2198,13 +2195,12 @@ bool PixelHarness::check_pelFilterChroma_H(pelFilterChroma_t ref, pelFilterChrom</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
bool PixelHarness::check_pelFilterChroma_V(pelFilterChroma_t ref, pelFilterChroma_t opt)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
{</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
intptr_t srcStep = 64, offset = 1;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- int32_t maskP, maskQ, tc;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
intptr_t j = 0;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
const int NUM_MASKS = 3;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
pixel pixel_test_buff1[TEST_CASES][BUFFSIZE];</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
for (int i = 0; i < TEST_CASES; i++)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- memcpy(pixel_test_buff1[i], pixel_test_buff[i], sizeof(pixel)* BUFFSIZE);</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ memcpy(pixel_test_buff1[i], pixel_test_buff[i], sizeof(pixel) * BUFFSIZE);</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int32_t masks[NUM_MASKS][2] = {{-1, -1}, {-1, 0}, {0, -1}};</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
@@ -2212,11 +2208,9 @@ bool PixelHarness::check_pelFilterChroma_V(pelFilterChroma_t ref, pelFilterChrom</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
{</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int32_t maskP = masks[i][0];</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int32_t maskQ = masks[i][1];</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
-</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- for (int i = 0; i < ITERS; i++)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ for (int k = 0; k < ITERS; k++)</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
{</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- tc = rand() % PIXEL_MAX;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
-</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ int32_t tc = rand() % PIXEL_MAX;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
int index = rand() % 3;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
ref(pixel_test_buff[index] + 2 * offset + j, srcStep, offset, tc, maskP, maskQ);</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
@@ -2225,7 +2219,7 @@ bool PixelHarness::check_pelFilterChroma_V(pelFilterChroma_t ref, pelFilterChrom</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
if (memcmp(pixel_test_buff[index], pixel_test_buff1[index], sizeof(pixel) * BUFFSIZE))</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
return false;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
- reportfail()</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
+ reportfail();</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
j += INCR;</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
}</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
}</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
2.43.0</div>
<div class="elementToProof" style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
<br>
</div>
<div style="font-family: Corbel, Skia, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
</body>
</html>