<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi,</div>
<div style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
It looks like the patch files weren’t included. Could you please provide the changes as an attached patch as well.</div>
<div style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks,</div>
<div style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Kirithika</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> x265-devel <x265-devel-bounces@videolan.org> on behalf of Richard <ccc7922@foxmail.com><br>
<b>Sent:</b> Saturday, March 28, 2026 6:31 AM<br>
<b>To:</b> x265-devel@videolan.org <x265-devel@videolan.org><br>
<b>Subject:</b> [x265] [PATCH] Fix chroma qp offsets for non-YUV444 inputs</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Mr-Z-2697 <74594146+Mr-Z-2697@users.noreply.github.com><br>
<br>
This reverts commit 2d01af69c4757b5087274e36e27b660b08244010<br>
and removes the m_psyRd ternary check.<br>
<br>
The removal of the m_psyRd check diverges from the x264 code, but if the check is in place, the offsets seem to be broken when psy-rd=0 (x264 doesn't have this issue).<br>
When psy-rd=0, the offsets have stronger effect than x264, but is more close to "6 in QP is double/half the quality/bitrate".<br>
---<br>
source/encoder/rdcost.h | 17 ++++++-----------<br>
1 file changed, 6 insertions(+), 11 deletions(-)<br>
<br>
diff --git a/source/encoder/rdcost.h b/source/encoder/rdcost.h<br>
index 1bd4dd696..acdbb3e01 100644<br>
--- a/source/encoder/rdcost.h<br>
+++ b/source/encoder/rdcost.h<br>
@@ -76,18 +76,13 @@ public:<br>
qpCr = x265_clip3(QP_MIN, QP_MAX_SPEC, qp + slice.m_pps->chromaQpOffset[1] + slice.m_chromaQpOffset[1]);<br>
}<br>
<br>
- if (slice.m_sps->chromaFormatIdc == X265_CSP_I444)<br>
- {<br>
- int chroma_offset_idx = X265_MIN(qp - qpCb + 12, MAX_CHROMA_LAMBDA_OFFSET);<br>
- uint16_t lambdaOffset = m_psyRd ? x265_chroma_lambda2_offset_tab[chroma_offset_idx] : 256;<br>
- m_chromaDistWeight[0] = lambdaOffset;<br>
+ int chroma_offset_idx = X265_MIN(qp - qpCb + 12, MAX_CHROMA_LAMBDA_OFFSET);<br>
+ uint16_t lambdaOffset = x265_chroma_lambda2_offset_tab[chroma_offset_idx];<br>
+ m_chromaDistWeight[0] = lambdaOffset;<br>
<br>
- chroma_offset_idx = X265_MIN(qp - qpCr + 12, MAX_CHROMA_LAMBDA_OFFSET);<br>
- lambdaOffset = m_psyRd ? x265_chroma_lambda2_offset_tab[chroma_offset_idx] : 256;<br>
- m_chromaDistWeight[1] = lambdaOffset;<br>
- }<br>
- else<br>
- m_chromaDistWeight[0] = m_chromaDistWeight[1] = 256;<br>
+ chroma_offset_idx = X265_MIN(qp - qpCr + 12, MAX_CHROMA_LAMBDA_OFFSET);<br>
+ lambdaOffset = x265_chroma_lambda2_offset_tab[chroma_offset_idx];<br>
+ m_chromaDistWeight[1] = lambdaOffset;<br>
}<br>
<br>
void setLambda(double lambda2, double lambda)<br>
--<br>
2.53.0.windows.2<br>
<br>
_______________________________________________<br>
x265-devel mailing list<br>
x265-devel@videolan.org<br>
<a href="https://mailman.videolan.org/listinfo/x265-devel">https://ind01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmailman.videolan.org%2Flistinfo%2Fx265-devel&data=05%7C02%7Ckirithika%40multicorewareinc.com%7C882f880a133f4a2e02a708de8c65b154%7Cffc5e88b3fa24d69a468344b6b766e7d%7C0%7C0%7C639102565634302575%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=M9W3279RbKDvy8A3RFOTfqxBpeq6F5s2k6tavgregpE%3D&reserved=0</a><br>
⚠️ External Email Warning: This message originated from outside the organization (McW).<br>
Be cautious - Never share passwords or click unexpected links/attachments.<br>
<br>
</div>
</span></font></div>
</body>
</html>