[Android] thumbnailer: variable use after deletion

Ludovic Fauvet git at videolan.org
Sun Apr 15 23:34:28 CEST 2012


android | branch: master | Ludovic Fauvet <etix at l0cal.com> | Sun Apr 15 23:29:07 2012 +0200| [4ee3ebc3067269d32956b51f63dabb5a0e854397] | committer: Ludovic Fauvet

thumbnailer: variable use after deletion

Catched by CheckJNI running on Android 4.0 and later.

> http://git.videolan.org/gitweb.cgi/android.git/?a=commit;h=4ee3ebc3067269d32956b51f63dabb5a0e854397
---

 vlc-android/jni/thumbnailer.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/vlc-android/jni/thumbnailer.c b/vlc-android/jni/thumbnailer.c
index dbeb30c..0231155 100644
--- a/vlc-android/jni/thumbnailer.c
+++ b/vlc-android/jni/thumbnailer.c
@@ -246,8 +246,6 @@ jbyteArray Java_org_videolan_vlc_LibVLC_getThumbnail(JNIEnv *env, jobject thiz,
     (*env)->SetByteArrayRegion(env, byteArray, 0, thumbnailSize,
                                  (jbyte *)sys->thumbnail);
 
-    (*env)->DeleteLocalRef(env, byteArray);
-
 end:
     pthread_mutex_destroy(&sys->doneMutex);
     pthread_cond_destroy(&sys->doneCondVar);



More information about the Android mailing list