[Android] Do not hardcode strings

Jean-Baptiste Kempf git at videolan.org
Sat Jun 30 09:26:42 CEST 2012


android | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Fri Jun 29 23:08:22 2012 +0200| [fc5b40655b5bb5add8fcd25e4f4a3bcfb0a42021] | committer: Jean-Baptiste Kempf

Do not hardcode strings

> http://git.videolan.org/gitweb.cgi/android.git/?a=commit;h=fc5b40655b5bb5add8fcd25e4f4a3bcfb0a42021
---

 vlc-android/res/values/strings.xml                     |    1 +
 vlc-android/src/org/videolan/vlc/gui/MainActivity.java |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/vlc-android/res/values/strings.xml b/vlc-android/res/values/strings.xml
index fc21d1d..3cdac27 100644
--- a/vlc-android/res/values/strings.xml
+++ b/vlc-android/res/values/strings.xml
@@ -83,6 +83,7 @@
     <string name="track_samplerate_info">Sample rate: %1$d Hz\n</string>
     <string name="track_resolution_info">Resolution: %1$dx%2$d\n</string>
     <string name="track_framerate_info">Frame rate: %1$.3f\n</string>
+    <string name="open">Open</string>
     <string name="open_mrl">Open MRL</string>
     <string name="open_mrl_dialog_title">Open network stream</string>
     <string name="open_mrl_dialog_msg">Enter network MRL: e.g. http://, mms:// or rtsp://</string>
diff --git a/vlc-android/src/org/videolan/vlc/gui/MainActivity.java b/vlc-android/src/org/videolan/vlc/gui/MainActivity.java
index f03fd3f..0f27ea7 100644
--- a/vlc-android/src/org/videolan/vlc/gui/MainActivity.java
+++ b/vlc-android/src/org/videolan/vlc/gui/MainActivity.java
@@ -450,7 +450,7 @@ public class MainActivity extends SherlockFragmentActivity {
         b.setTitle(R.string.open_mrl_dialog_title);
         b.setMessage(R.string.open_mrl_dialog_msg);
         b.setView(input);
-        b.setPositiveButton("Open", new DialogInterface.OnClickListener() {
+        b.setPositiveButton(R.string.open, new DialogInterface.OnClickListener() {
             @Override
             public void onClick(DialogInterface dialog, int button) {
                 ProgressDialog pd = ProgressDialog.show(



More information about the Android mailing list