[Android] You shall return an int, when your prototype is an int...

Jean-Baptiste Kempf git at videolan.org
Wed Oct 3 11:26:10 CEST 2012


vlc-ports/android | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Oct  3 11:25:46 2012 +0200| [3b8bc023780096def3b3c8ffa5bd643bd9013d75] | committer: Jean-Baptiste Kempf

You shall return an int, when your prototype is an int...

> http://git.videolan.org/gitweb.cgi/vlc-ports/android.git/?a=commit;h=3b8bc023780096def3b3c8ffa5bd643bd9013d75
---

 vlc-android/jni/libvlcjni.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/vlc-android/jni/libvlcjni.c b/vlc-android/jni/libvlcjni.c
index 9736023..9a27c95 100644
--- a/vlc-android/jni/libvlcjni.c
+++ b/vlc-android/jni/libvlcjni.c
@@ -617,7 +617,7 @@ jint Java_org_videolan_vlc_LibVLC_readMedia(JNIEnv *env, jobject thiz,
     if (!m)
     {
         LOGE("readMedia: Could not create the media!");
-        return;
+        return -1;
     }
 
     libvlc_media_list_t* p_mlist = getMediaList(env, thiz);
@@ -627,7 +627,7 @@ jint Java_org_videolan_vlc_LibVLC_readMedia(JNIEnv *env, jobject thiz,
         LOGE("readMedia: Could not add to the media list!");
         libvlc_media_list_unlock(p_mlist);
         libvlc_media_release(m);
-        return;
+        return -1;
     }
     int position = libvlc_media_list_index_of_item(p_mlist, m);
     libvlc_media_list_unlock(p_mlist);



More information about the Android mailing list