[Android] video: don't stop in onDestroy, playback has already been stopped in onPause

Sébastien Toque git at videolan.org
Sun Dec 15 14:47:38 CET 2013


vlc-ports/android | branch: master | Sébastien Toque <xilasz at gmail.com> | Sun Dec 15 14:47:30 2013 +0100| [1d6273170d7034c23f91adc42798f80b20022f8f] | committer: Sébastien Toque

video: don't stop in onDestroy, playback has already been stopped in onPause

This is not necessary anymore.
It was also causing a bug where a video would stop at startup
if launched immediately after closing another video.
onDestroy from the first video was fired after the second video was started,
and it was stopping the second one.

> http://git.videolan.org/gitweb.cgi/vlc-ports/android.git/?a=commit;h=1d6273170d7034c23f91adc42798f80b20022f8f
---

 vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
index b5485e0..5a66ed3 100644
--- a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
+++ b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
@@ -395,9 +395,6 @@ public class VideoPlayerActivity extends Activity implements IVideoPlayer {
     protected void onDestroy() {
         super.onDestroy();
         unregisterReceiver(mReceiver);
-        if (mLibVLC != null && !mSwitchingView) {
-            mLibVLC.stop();
-        }
 
         EventHandler em = EventHandler.getInstance();
         em.removeHandler(eventHandler);



More information about the Android mailing list