[Android] [PATCH] thumbnailer: do not wait until video position becomes *strictly* superior to THUMBNAIL_POSITION.

[Rafaël Carré]

Right, patch is OK.

May I ask why you prefer pre increment though?


Felix Abecassis <felix.abecassis at gmail.com> a écrit :
>No.
>
>http://stackoverflow.com/questions/4706199/post-increment-and-pre-increment-within-a-for-loop-produce-same-output
>
>
>2013/11/27 Rafaël Carré <rafael.carre at gmail.com>
>
>> Sorry but with ++i compared to i++ that makes 99 attempts no?
>>
>>
>> Felix Abecassis <felix.abecassis at gmail.com> a écrit :
>>
>>> Avoid waiting unnecessarily when the media player reaches exactly
>THUMBNAIL_POSITION. However we must now wait until libvlc updates the
>position before polling with libvlc_media_player_get_position().
>>>
>>> ---
>>> vlc-android/jni/thumbnailer.c | 10 +++++-----
>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/vlc-android/jni/thumbnailer.c
>b/vlc-android/jni/thumbnailer.c
>>> index 2d41a59..1f65ed7 100644
>>>
>>> --- a/vlc-android/jni/thumbnailer.c
>>> +++ b/vlc-android/jni/thumbnailer.c
>>> @@ -263,12 +263,12 @@ jbyteArray
>Java_org_videolan_libvlc_LibVLC_getThumbnail(JNIEnv *env, jobject thi
>>> libvlc_media_player_play(mp);
>>> libvlc_media_player_set_position(mp, THUMBNAIL_POSITION);
>>>
>>> -    int loops = 100;
>>> -    for (;;) {
>>> -        float pos = libvlc_media_player_get_position(mp);
>>> -        if (pos > THUMBNAIL_POSITION || !loops--)
>>> +    const int wait_time = 50000;
>>> +    const int max_attempts =
>>> 100;
>>> +    for (int i = 0; i < max_attempts; ++i) {
>>> +        if (libvlc_media_player_is_playing(mp) &&
>libvlc_media_player_get_position(mp) >= THUMBNAIL_POSITION)
>>> break;
>>> -        usleep(50000);
>>>
>>> +        usleep(wait_time);
>>> }
>>>
>>> /* Wait for the thumbnail to be generated. */
>>>
>>>
>> --
>> Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.
>>
>> _______________________________________________
>> Android mailing list
>> Android at videolan.org
>> https://mailman.videolan.org/listinfo/android
>>
>>
>
>
>-- 
>Félix Abecassis
>http://felix.abecassis.me
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Android mailing list
>Android at videolan.org
>https://mailman.videolan.org/listinfo/android

-- 
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20131127/5b0375f1/attachment.html>