[Android] libvlc: Don't try to load the iomx library on kitkat

Martin Storsjö git at videolan.org
Wed Nov 27 15:34:40 CET 2013


vlc-ports/android | branch: master | Martin Storsjö <martin at martin.st> | Wed Nov 27 16:19:11 2013 +0200| [419c6d9d4f32f34a8bf9cd562a8d2cd1490e8822] | committer: Martin Storsjö

libvlc: Don't try to load the iomx library on kitkat

MediaCodec should be preferred over iomx, since the former is a
public API, and is always availble on kitkat. The IOMX ABI has
changed between jb_mr2 (which used the -ics binary) and kitkat,
and trying to load the -ics binary will actually succeed, but
will crash if one tries to use it.

The VLC MediaCodec module currently only supports video but not
audio, but there's seldom any point in using IOMX for audio
anyway, and if this actually is an issue, the MediaCodec module
can be updated to support audio decoding as well.

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/vlc-ports/android.git/?a=commit;h=419c6d9d4f32f34a8bf9cd562a8d2cd1490e8822
---

 vlc-android/src/org/videolan/libvlc/LibVLC.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vlc-android/src/org/videolan/libvlc/LibVLC.java b/vlc-android/src/org/videolan/libvlc/LibVLC.java
index c66a0ef..77c985e 100644
--- a/vlc-android/src/org/videolan/libvlc/LibVLC.java
+++ b/vlc-android/src/org/videolan/libvlc/LibVLC.java
@@ -83,7 +83,7 @@ public class LibVLC {
                 System.loadLibrary("iomx-gingerbread");
             else if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.HONEYCOMB_MR2)
                 System.loadLibrary("iomx-hc");
-            else
+            else if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.JELLY_BEAN_MR2)
                 System.loadLibrary("iomx-ics");
         } catch (Throwable t) {
             Log.w(TAG, "Unable to load the iomx library: " + t);



More information about the Android mailing list