[Android] [PATCH] Add support for multiple video instances.

[Thomas Guillem]

On Tue, Dec 2, 2014, at 14:04, Paulo Vitor Magacho da Silva wrote:
> Hi,
>
> Ok. Will provide both commits.
>
> Will update the name as well. Can it be "Add support for multiple
> video instances for Android." ?
>
> I will check the discrepancy between drawable-vlcobject and
> drawable-androidobject.
>
> I am using the android_surf_value_t members to check if the surface
> was destroyed so I it can be re-attached. To fix this, I will create a
> method in the android libvlc JNI code to check that. This way I don't
> have to use the struct member. Is that ok ? If yes, I will make a new
> commit for Android code and VLC. Should do it later today. This
> functionality is interesting, because if you hide the SurfaceView and
> show it again, the video can continue to be displayed in the new
> Surface object. While the SurfaceView is hidden, no image is sent to
> the display, since the Surface object was destroyed.

Ok, It might be interesting, but you have to do that in a separate
commit. I missed that code when I reviewed your patch.

> Thank you for all the help.
>
> After all this is ok, I will work on changing the onPause/onResume
> methods to use the pause function, instead of the stop, if that is ok.
I'm curious, In which case you don't want to stop the video when you
hit onPause ?

>
> Cheers, Paulo
>
> 2014-12-02 10:50 GMT-02:00 Thomas Guillem <thomas at gllm.fr>:
>> You should do 2 commits, one that touch
>> include/vlc/libvlc_media_player.h lib/media_player.c and
>> src/libvlc.c. This commit should be about adding
>> libvlc_media_player_set_androidobject into libvlc. The others commits
>> should touch modules.
>>
>> The name "Add support for multiple video instances" is not good, vlc
>> is not only about android, and support multiple video instance for
>> other platforms since a long time.
>>
>> At the end, in src/libvlc.c why drawable-vlcobject and not
>> drawable-androidobject ?
>>
>> You don't have to specify again struct android_surf_value_t in vlc.
>> You can do: typedef struct android_surf_value_t android_surf_value_t;
>> vlc shouldn't have access to android_surf_value_t members.
>>
>> Some comments don't match the function name (surfacevalue vs
>> androidobject)
>> _______________________________________________
>> Android mailing list Android at videolan.org
>> https://mailman.videolan.org/listinfo/android
>
> _________________________________________________
> Android mailing list Android at videolan.org
> https://mailman.videolan.org/listinfo/android

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20141202/b3f49bf0/attachment.html>