[Android] Audio browser: remove the append all function as read all offers the same functionality

Adrien Maglo git at videolan.org
Fri Jan 17 10:01:50 CET 2014


vlc-ports/android | branch: master | Adrien Maglo <magsoft at videolan.org> | Thu Jan 16 18:52:05 2014 +0100| [8527cac4f8fe9a2bc819d9b55abccae8ce0c2fb2] | committer: Adrien Maglo

Audio browser: remove the append all function as read all offers the same functionality

> http://git.videolan.org/gitweb.cgi/vlc-ports/android.git/?a=commit;h=8527cac4f8fe9a2bc819d9b55abccae8ce0c2fb2
---

 vlc-android/res/menu/audio_list_browser.xml                   |    9 +++------
 .../org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java  |    6 ++----
 .../src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java  |    6 ++----
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/vlc-android/res/menu/audio_list_browser.xml b/vlc-android/res/menu/audio_list_browser.xml
index 7bdfa5b..12a5d28 100644
--- a/vlc-android/res/menu/audio_list_browser.xml
+++ b/vlc-android/res/menu/audio_list_browser.xml
@@ -10,12 +10,9 @@
 	    <item
 	        android:id="@+id/audio_list_browser_play_all"
 	        android:title="@string/play_all" />
-	    <item
-	        android:id="@+id/audio_list_browser_append_all"
-	        android:title="@string/append_all" />
-	    <item
-	        android:id="@+id/audio_list_browser_delete"
-	        android:title="@string/delete"/>
+        <item
+           android:id="@+id/audio_list_browser_delete"
+           android:title="@string/delete"/>
     </group>
     <group android:id="@+id/phone_only" >
 	    <item
diff --git a/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java b/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java
index 199d3c0..c48ff4a 100644
--- a/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java
@@ -199,10 +199,8 @@ public class AudioAlbumsSongsFragment extends SherlockFragment {
         List<String> medias;
         int id = item.getItemId();
 
-        boolean useAllItems = (id == R.id.audio_list_browser_play_all ||
-                               id == R.id.audio_list_browser_append_all);
-        boolean append = (id == R.id.audio_list_browser_append ||
-                          id == R.id.audio_list_browser_append_all);
+        boolean useAllItems = id == R.id.audio_list_browser_play_all;
+        boolean append = id == R.id.audio_list_browser_append;
 
         if (ExpandableListContextMenuInfo.class.isInstance(menuInfo)) {
             ExpandableListContextMenuInfo info = (ExpandableListContextMenuInfo) menuInfo;
diff --git a/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java b/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java
index 2718927..5246c11 100644
--- a/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java
@@ -233,10 +233,8 @@ public class AudioBrowserFragment extends SherlockFragment {
         List<String> medias;
         int id = item.getItemId();
 
-        boolean useAllItems = (id == R.id.audio_list_browser_play_all ||
-                               id == R.id.audio_list_browser_append_all);
-        boolean append = (id == R.id.audio_list_browser_append ||
-                          id == R.id.audio_list_browser_append_all);
+        boolean useAllItems = id == R.id.audio_list_browser_play_all;
+        boolean append = id == R.id.audio_list_browser_append;
 
         if (ExpandableListContextMenuInfo.class.isInstance(menuInfo)) {
             ExpandableListContextMenuInfo info = (ExpandableListContextMenuInfo) menuInfo;



More information about the Android mailing list