[Android] [PATCH] Replace HW acceleration checkbox by a list allowing the user to choose which mode to use

Jean-Baptiste Kempf jb at videolan.org
Tue Jan 21 22:02:40 CET 2014


On 21 Jan, Martin Storsjö wrote :
> On Tue, 21 Jan 2014, Felix Abecassis wrote:
> 
> >There are currently 4 modes:
> >- Automatic: let VLC decide whether hardware acceleration should be used (default).
> 
> It would be nice if the commit message said what the auto mode does. I dug
> through the code and found that it enables it by default on >= 4.3 and
> disables it otherwise. That might be a sane choice in general, but since
> we've got the opaque rendering now, it might actually work pretty well on
> 4.1 and 4.2 as well (it's mostly the pixel access which has been
> underspecified and which has been improved in 4.3, direct rendering has
> mostly worked I think, and as far as I've seen, that case has been the main
> focus of those who made the MediaCodec API).

Well, I wanted to be on the safe side, so I said try 4.3, but we could
add more when tested :)
Or activate devices one by one.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the Android mailing list