[Android] [PATCH] Replace HW acceleration checkbox by a list allowing the user to choose which mode to use

[Felix Abecassis]

2014/1/22 XilasZ <xilasz at gmail.com>:
>
>> > I would rather take the opposite approach, can we find a device in the
>> > 4.1 to 4.2 range which does not work correctly with opaque rendering?
>> > Please test the Hardware Acceleration option if you have such devices!
>>
>> That's pretty dangerous, seeing the number of crappy devices...
>> And seeing the number of hi-ref-frames files people can use...
>
>
> At least on my HTC One X (tegra3, android 4.2.2), we can't enable it by
> default yet.
> Here some tests i did, with a simple 720p h264 mkv (a show) :
>
> - SW
>   => everything plays fine, both frames and subtitles and both vouts
>
> - HW without DR
>   => it works, both frames and subtitles and both vouts, but way too slow,
> probably because of slow memory and limited bandwith
>
> - HW + DR
>   => with surface vout, works from video list, but without any subtitles
>           lots of "blend blend: no matching alpha blending routine (chroma:
> RGBA -> ANOP)" in the logs
This is "normal" since the patch for subtitles hasn't been merged yet.
I have a patch for simply hiding this error but it does not enable
subtitles.
I suggest we wait for the subtitles patch, I just have one issue left to solve.

But the real question here is: are the performance better than SW in this case?

>
>   => with opengles vout, playback starts, but the UI switchs to audio only
> because vouts fails to start :
>           01-22 07:50:18.251: E/libEGL(20227): EGLNativeWindowType
> 0x6016f980 already connected to another API
>           01-22 07:50:18.251: E/libEGL(20227): eglCreateWindowSurface:407
> error 300b (EGL_BAD_NATIVE_WINDOW)
>           01-22 07:50:18.251: E/VLC(20227): egl_android gl: cannot create
> EGL window surface
These two modes are not compatible, I will submit a patch so that the
OpenGL vout cannot be activated if HW+DR is picked from the list.

>
>   => when starting from directoryview, it freeze when starting,  feels like
> a deadlock
I'm confused, how is this mode different from the above one?

-- 
Félix Abecassis
http://felix.abecassis.me