[Android] UI: remove useless list item divider

Adrien Maglo git at videolan.org
Tue Mar 4 14:06:40 CET 2014


vlc-ports/android | branch: master | Adrien Maglo <magsoft at videolan.org> | Tue Mar  4 14:03:51 2014 +0100| [03e3dd0a676fa31a3d58d1e3e4b306062b0396a6] | committer: Adrien Maglo

UI: remove useless list item divider

> http://git.videolan.org/gitweb.cgi/vlc-ports/android.git/?a=commit;h=03e3dd0a676fa31a3d58d1e3e4b306062b0396a6
---

 vlc-android/res/layout/browser.xml        |    4 +---
 vlc-android/res/layout/directory_view.xml |    4 +---
 vlc-android/res/layout/history_list.xml   |    4 +---
 vlc-android/res/layout/search.xml         |    2 --
 vlc-android/res/values/attrs.xml          |    1 -
 vlc-android/res/values/colors.xml         |    1 -
 vlc-android/res/values/styles.xml         |    3 ---
 7 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/vlc-android/res/layout/browser.xml b/vlc-android/res/layout/browser.xml
index 60bd3b5..47b6083 100644
--- a/vlc-android/res/layout/browser.xml
+++ b/vlc-android/res/layout/browser.xml
@@ -5,7 +5,5 @@
               android:orientation="vertical">
     <ListView android:id="@id/android:list"
               android:layout_width="fill_parent"
-              android:layout_height="fill_parent"
-              android:divider="?attr/item_divider"
-              android:dividerHeight="1dp" />
+              android:layout_height="fill_parent" />
 </LinearLayout>
\ No newline at end of file
diff --git a/vlc-android/res/layout/directory_view.xml b/vlc-android/res/layout/directory_view.xml
index 99531b2..81600e8 100644
--- a/vlc-android/res/layout/directory_view.xml
+++ b/vlc-android/res/layout/directory_view.xml
@@ -4,8 +4,6 @@
     android:paddingLeft="20dp"
     android:paddingRight="20dp"
     android:layout_width="match_parent"
-    android:layout_height="match_parent"
-    android:divider="?attr/item_divider"
-    android:dividerHeight="1dp" >
+    android:layout_height="match_parent" >
 
 </ListView>
diff --git a/vlc-android/res/layout/history_list.xml b/vlc-android/res/layout/history_list.xml
index 9e252d9..53bee3a 100644
--- a/vlc-android/res/layout/history_list.xml
+++ b/vlc-android/res/layout/history_list.xml
@@ -7,9 +7,7 @@
     <ListView
         android:id="@android:id/list"
         android:layout_width="match_parent"
-        android:layout_height="match_parent"
-        android:divider="?attr/item_divider"
-        android:dividerHeight="1dp" />
+        android:layout_height="match_parent" />
 
     <TextView
         android:id="@android:id/empty"
diff --git a/vlc-android/res/layout/search.xml b/vlc-android/res/layout/search.xml
index b6018ac..87f1fc7 100644
--- a/vlc-android/res/layout/search.xml
+++ b/vlc-android/res/layout/search.xml
@@ -34,7 +34,5 @@
         android:id="@id/android:list"
         android:layout_width="fill_parent"
         android:layout_height="fill_parent"
-        android:divider="?attr/item_divider"
-        android:dividerHeight="1dp"
         android:fastScrollEnabled="true" />
 </LinearLayout>
diff --git a/vlc-android/res/values/attrs.xml b/vlc-android/res/values/attrs.xml
index 86ca592..2b5a742 100644
--- a/vlc-android/res/values/attrs.xml
+++ b/vlc-android/res/values/attrs.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
 
-    <attr name="item_divider" format="reference|color" />
     <attr name="item_common_pressed" format="reference|color" />
     <attr name="item_common_selected" format="reference|color" />
     <attr name="item_footer" format="reference|color" />
diff --git a/vlc-android/res/values/colors.xml b/vlc-android/res/values/colors.xml
index f095066..838f837 100644
--- a/vlc-android/res/values/colors.xml
+++ b/vlc-android/res/values/colors.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
 
-    <color name="item_divider">#00000000</color>
     <color name="item_common_pressed">#e0e0e0</color>
     <color name="item_common_selected">#5e5e5e</color>
     <color name="item_footer">#e0e0e0</color>
diff --git a/vlc-android/res/values/styles.xml b/vlc-android/res/values/styles.xml
index 1ee5a99..fcbb35a 100644
--- a/vlc-android/res/values/styles.xml
+++ b/vlc-android/res/values/styles.xml
@@ -20,7 +20,6 @@
         <item name="android:expandableListViewStyle">@style/Theme.VLC.List</item>
         <item name="android:dropDownListViewStyle">@style/Theme.VLC.List</item>
 
-        <item name="item_divider">@color/item_divider</item>
         <item name="item_common_pressed">@color/item_common_pressed</item>
         <item name="item_common_selected">@color/item_common_selected</item>
         <item name="item_footer">@color/item_footer</item>
@@ -72,7 +71,6 @@
         <item name="android:expandableListViewStyle">@style/Theme.VLC.List</item>
         <item name="android:dropDownListViewStyle">@style/Theme.VLC.List</item>
 
-        <item name="item_divider">@color/item_divider</item>
         <item name="item_common_pressed">@color/item_common_pressed</item>
         <item name="item_common_selected">@color/item_common_selected</item>
         <item name="item_footer">@color/grey1</item>
@@ -117,7 +115,6 @@
     </style>
 
     <style name="Theme.VLC.NoTitleBar" parent="Theme.Sherlock.Light.NoActionBar">
-        <item name="item_divider">@color/item_divider</item>
         <item name="item_common_pressed">@color/item_common_pressed</item>
         <item name="item_common_selected">@color/item_common_selected</item>
         <item name="item_footer">@color/item_footer</item>



More information about the Android mailing list