[Android] [PATCH] Support build without iconv

Uwe L. Korn uwelk at xhochy.com
Wed May 21 19:29:45 CEST 2014


Is there any chance for further review or better to get this (and the
other patch) merged?

On 14/05/14 13:15, Uwe L. Korn wrote:
> On 14/05/14 13:00, Jean-Baptiste Kempf wrote:
>> On 14 May, Edward Wang wrote :
>>> On Wed, May 14, 2014 at 4:38 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>>> On 13 May, Uwe L. Korn wrote :
>>>>> Make building iconv optional via setting the environment variable
>>>>> VLC_USE_ICONV=0, this is given correctly to VLC's contrib system
>>>>> and the linking process of libvlcjni.so
>>>>
>>>> Be EXTRA-CAREFUL when removing iconv. Things like smooth streaming,
>>>> subtitles, MMS, ASF, AVI/WAV, NSC, WMV or even TS might not work
>>>> correctly.
>>>
>>> The bigger question is: why would you want to disable it in the first place?
>>
>> Size.
> 
> Just to clarify my intentions with my patches: We are using libvlc for
> audio streaming in Tomahawk on Android. We do not need any video related
> stuff at the moment. As 12-14MB is a substantial increase in size by
> adding libvlc to our app, I want to strip unnecessary parts out of
> libvlcjni.so. And yes, I'm aware that I might break things in libvlc by
> stripping out things that might be needed for audio, even if they might
> make the impression being for video only ;)
> 
> Uwe
> 
> 
> 
> 
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/android/attachments/20140521/b068819a/attachment.sig>


More information about the Android mailing list