[Android] New StatusBar design for Video Player
XilasZ
xilasz at gmail.com
Thu Oct 2 12:17:50 CEST 2014
I did something similar locally, and it works, you can push :) (i don't
have access from here).
Le 2 oct. 2014 11:47, "Thomas Guillem" <thomas.guillem at gmail.com> a écrit :
> A lof of status/nav bar things have been fixed on Android 4.2. You
> don't need any hack after that version.
> Could you test my last patch please ?
>
> On Thu, Oct 2, 2014 at 11:05 AM, XilasZ <xilasz at gmail.com> wrote:
> > Maybe. On my device i don't have a nav bar at all, playing with it
> messed up
> > HTC Sense (don't remember the details, that was two years ago:p), but
> looks
> > like it doesn't happen anymore, or it has been fixed by others commits.
> >
> > Le 2 oct. 2014 10:58, "Thomas Guillem" <thomas.guillem at gmail.com> a
> écrit :
> >
> >> In AndroidDevices.java:
> >> Maybe the navBar check should be something like:
> >> hasNavBar = LibVlcUtil.isJellyBeanMR1OrLater() ||
> >> (LibVlcUtil.isICSOrLater() &&
> >> !devicesWithoutNavBar.contains(android.os.Build.MODEL));
> >>
> >> Because, I think after JBMR1, we can always show/hide status and nav
> bar.
> >>
> >> On Thu, Oct 2, 2014 at 10:49 AM, XilasZ <xilasz at gmail.com> wrote:
> >> > The issue is that dimStatusBar is blocked on some devices with
> >> > hasNavBar()
> >> > (i did that long time ago, because weird stuff happened when hiding
> >> > inexistant navbar on HTC OneX), and the fullscreen flag is not set.
> >> >
> >> > i removed the test and everything seems to work as it should, i'll
> keep
> >> > testing, see if there is no side effects.
> >> >
> >> > Le 2 oct. 2014 09:32, "XilasZ" <xilasz at gmail.com> a écrit :
> >> >
> >> >> Hi,
> >> >>
> >> >> I just tested this, and unfortunately the status bar never hides for
> me
> >> >> (HTC One X, 4.2.2).
> >> >> I guess that's not the expected behavior, i'll take a look at it.
> >> >>
> >> >> Le 2 oct. 2014 09:24, "Thomas Guillem" <thomas.guillem at gmail.com> a
> >> >> écrit
> >> >> :
> >> >>>
> >> >>> Thanks you for pushing my patches.
> >> >>> So I guess you agree with the new design.
> >> >>> The patches I proposed yesterday didn't enable transparency for
> >> >>> Android 4.4, I'll propose the new patch for that.
> >> >>>
> >> >>> Regards,
> >> >>> Thomas.
> >> >>>
> >> >>> On Wed, Oct 1, 2014 at 6:32 PM, Edward Wang
> >> >>> <edward.c.wang at compdigitec.com> wrote:
> >> >>> > On Wed, Oct 1, 2014 at 6:42 AM, Geoffrey Metais
> >> >>> > <geoffrey.metais at gmail.com> wrote:
> >> >>> >> I would prefer the title to be centered horizontally.
> >> >>> >>
> >> >>> >> Apart from that, it's fine.
> >> >>> >
> >> >>> >
> >> >>> > I would prefer to keep the title the way it is now, just for
> >> >>> > consistency.
> >> >>> >
> >> >>> > Regards,
> >> >>> > Edward
> >> >>> > _______________________________________________
> >> >>> > Android mailing list
> >> >>> > Android at videolan.org
> >> >>> > https://mailman.videolan.org/listinfo/android
> >> >>> _______________________________________________
> >> >>> Android mailing list
> >> >>> Android at videolan.org
> >> >>> https://mailman.videolan.org/listinfo/android
> >> >
> >> >
> >> > _______________________________________________
> >> > Android mailing list
> >> > Android at videolan.org
> >> > https://mailman.videolan.org/listinfo/android
> >> >
> >> _______________________________________________
> >> Android mailing list
> >> Android at videolan.org
> >> https://mailman.videolan.org/listinfo/android
> >
> >
> > _______________________________________________
> > Android mailing list
> > Android at videolan.org
> > https://mailman.videolan.org/listinfo/android
> >
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20141002/3881519d/attachment.html>
More information about the Android
mailing list