[Android] [PATCH] Gamepad controll for VideoPlayer

[Geoffrey Métais]

I tip overlay will be done for TV, because the current one does not apply.

And I changed my Eclipse settings for tabs this morning :p

On Mon, Oct 6, 2014 at 3:54 PM, Edward Wang <edward.c.wang at compdigitec.com>
wrote:

> Hi Geoffrey,
>
> On Mon, Oct 6, 2014 at 2:54 AM, Geoffrey Métais
> <geoffrey.metais at gmail.com> wrote:
> > Here is the mapping
> >
> > A : play/pause
> > B : Audio Track
> > X : toggle mute
> > Y : Select subtitle
> > R1 : seek forward
> > L1 : seek backward
> >
> > Left stick:
> > Horizontal axis: seek
> > Vertical axis : brightness
> >
> > Right stick:
> > Vertical axis: volume
> >
> > Please tell me if you have a better idea of configuration
> > ---
> >  .../vlc/gui/video/VideoPlayerActivity.java         | 68
> +++++++++++++++++++---
> >  .../src/org/videolan/vlc/util/AndroidDevices.java  | 22 +++++++
> >  2 files changed, 82 insertions(+), 8 deletions(-)
>
> It looks mostly good. I had just a few comments in mind:
>
> 1) The vertical axis for brightness should respect the setting in the
> preferences. Some people may not wish to have their brightness changed
> by VLC during playback or may prefer to manage it themselves, and it
> should respect the preference for that.
>
> 2) This mapping should be documented somewhere. If I, as a user,
> didn't know this, it would be a lot of guesswork to figure out which
> button is doing what.
>
> 3) Some tab/spacing problems seem to have snuck into the patch ;)
>
> Regards,
> Edward
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20141006/8bff3c35/attachment.html>