[Android] [PATCH] AudioBrowserFragment: focus related functional improvement

Geoffrey Métais geoffrey.metais at gmail.com
Wed Oct 15 16:29:09 CEST 2014


I pushed with some modifications:

- generateViewId() is an API 17 method, I backported it into Util.java to
have it.
- there was a crash when audiolist was empty.
- i change the way menu_controls ids table is filled, to get it more
dynamic, and avoid hard-coded ids.

There is still a bug, when I re-launch VLC when I left it on audiobrowser
fragment, focus is not correctly set.
And generally, it still happens to get blocked when we navigate by keys.

I hope you will find out why.


On Tue, Oct 14, 2014 at 2:58 PM, Geoffrey Métais <geoffrey.metais at gmail.com>
wrote:

> No sorry, I meant reformatting according to Edward's comments.
> I understood you re-submit them according to his remarks.
>
> On Tue, Oct 14, 2014 at 2:55 PM, Mik Amchislavsky <hailmikhail at gmail.com>
> wrote:
>
>> Hi Geoffrey,
>>
>> >>> I wait to have your patches reformatted to test and merge it :)
>>
>> Are you still having problems with the format ?
>>
>> I am able to apply the copy sent on Oct 12th of "[Android] [PATCH]
>> AudioBrowserFragment: focus related functional improvement" to master
>> commit 4810f7d4535fc1b82520417c76920f5ef07db4b0.
>>
>> To apply I use the following command.
>>
>> git apply ./patches/my_patch_file
>>
>> What error does git give you when you try to apply this patch ? other
>> patches ?
>>
>> Regards,
>>
>> Mik
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20141015/48999da8/attachment.html>


More information about the Android mailing list