[Android] [PATCH] AudioBrowserFragment: focus related functional improvement

[Geoffrey Métais]

I systemically reproduce when I go to settings then come back to main
activity, with no audioplayer displayed.

On Thu, Oct 16, 2014 at 11:11 AM, Geoffrey Métais <geoffrey.metais at gmail.com
> wrote:

> - menu_controls : I did not really intend, we can reduce back to the ones
> shown as actions yes...
>
> About the focus blocked, it mostly happens when I leave VLC by pressing
> home, then launch it back. In this case, with keys navigation I'm trapped
> in actions items.
>
> And yes, you can work on master now, we pushed your patch to move forward
> even if it's not yet 100% okay ;)
>
> On Wed, Oct 15, 2014 at 10:25 PM, Mik Amchislavsky <hailmikhail at gmail.com>
> wrote:
>
>> Hi Geoffrey,
>>
>> >>> I pushed with some modifications:
>>
>> OK. Edward wanted me to make some changes. Unless you tell me otherwise,
>> I'll patch against bcce553c4a68d9c947ac144615c61039be1960a7.
>>
>> >>> - generateViewId() is an API 17 method, I backported it into
>> Util.java to have it.
>>
>> Great. Thank you.
>>
>> I would have preferred to assign the ID through resource files but, don't
>> see a way to do this because the framework creates home dynamically. Do I
>> understand home creation correctly or am I missing something ?
>>
>> >>> - menu_controls... get it more dynamic, and avoid hard-coded ids.
>>
>> I see the change to setMenuFocusDown. The hard coded list only contained
>> menu items with "vlc:showAsAction" attribute set to "ifRoom". Did you
>> intend to update all the menu items, including those in the pop-up, menu
>> made visible by the "Settings" key ?
>>
>> >>> ... focus is not correctly set ... get blocked ... I hope you will
>> find out why.
>>
>> OK. This weekend, I'll play with bcce553c4a68d9c947ac144615c61039be1960a7.
>>
>> I posted your 2 concerns to 11927. Please update this thread, as needed.
>> https://trac.videolan.org/vlc/ticket/11927
>>
>> What do you mean by "And generally, it still happens to get blocked when
>> we navigate by keys." ?
>> To help me understand this issue, would you please identify the starting
>> point, the sequence of input events, and the resulting state you consider
>> to be faulty ?
>>
>> Rather than allow free reign, I want to limit focus change flexibility to
>> simplify implementation and the user experience. As an example, once the
>> focus reaches the sliding menu I do not want the user to leave the menu
>> without selecting a menu item. This restriction allows a resource file
>> driven implementation and reduces likely outcomes to simplify testing and
>> error handling with minimal impact to the user experience.
>>
>> Regards,
>>
>> Mik
>>
>> On Wed, Oct 15, 2014 at 7:29 AM, Geoffrey Métais <
>> geoffrey.metais at gmail.com> wrote:
>>
>>> I pushed with some modifications:
>>>
>>> - generateViewId() is an API 17 method, I backported it into Util.java
>>> to have it.
>>> - there was a crash when audiolist was empty.
>>> - i change the way menu_controls ids table is filled, to get it more
>>> dynamic, and avoid hard-coded ids.
>>>
>>> There is still a bug, when I re-launch VLC when I left it on
>>> audiobrowser fragment, focus is not correctly set.
>>> And generally, it still happens to get blocked when we navigate by keys.
>>>
>>> I hope you will find out why.
>>>
>>>
>>> On Tue, Oct 14, 2014 at 2:58 PM, Geoffrey Métais <
>>> geoffrey.metais at gmail.com> wrote:
>>>
>>>> No sorry, I meant reformatting according to Edward's comments.
>>>> I understood you re-submit them according to his remarks.
>>>>
>>>> On Tue, Oct 14, 2014 at 2:55 PM, Mik Amchislavsky <
>>>> hailmikhail at gmail.com> wrote:
>>>>
>>>>> Hi Geoffrey,
>>>>>
>>>>> >>> I wait to have your patches reformatted to test and merge it :)
>>>>>
>>>>> Are you still having problems with the format ?
>>>>>
>>>>> I am able to apply the copy sent on Oct 12th of "[Android] [PATCH]
>>>>> AudioBrowserFragment: focus related functional improvement" to master
>>>>> commit 4810f7d4535fc1b82520417c76920f5ef07db4b0.
>>>>>
>>>>> To apply I use the following command.
>>>>>
>>>>> git apply ./patches/my_patch_file
>>>>>
>>>>> What error does git give you when you try to apply this patch ? other
>>>>> patches ?
>>>>>
>>>>> Regards,
>>>>>
>>>>> Mik
>>>>>
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20141016/d7ae0f93/attachment.html>