[Android] [PATCH 5/5] Revert "Do not handle msg if activity is finishing"

Geoffrey Métais geoffrey.metais at gmail.com
Tue Mar 17 11:33:32 CET 2015


LGTM for all 5 patches

On Tue, Mar 17, 2015 at 10:14 AM, Thomas Guillem <thomas at gllm.fr> wrote:

> This reverts commit bcc71ef19234269f39085e5841eb006c96b22dd6.
>
> It's better to remove event handler and clear events.
> ---
>  vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
> b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
> index 146a712..2e8b695 100644
> --- a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
> +++ b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java
> @@ -1292,7 +1292,7 @@ public class VideoPlayerActivity extends
> ActionBarActivity implements IVideoPlay
>          @Override
>          public void handleMessage(Message msg) {
>              VideoPlayerActivity activity = getOwner();
> -            if(activity == null || activity.isFinishing()) return;
> +            if(activity == null) return;
>              // Do not handle events if we are leaving the
> VideoPlayerActivity
>              if (activity.mSwitchingView) return;
>
> --
> 2.1.3
>
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20150317/82edaeb4/attachment-0001.html>


More information about the Android mailing list