[Android] Don't use attr color for textview background

Geoffrey Métais git at videolan.org
Tue Jul 5 18:09:27 CEST 2016


vlc-android | branch: master | Geoffrey Métais <geoffrey.metais at gmail.com> | Tue Jul  5 18:01:06 2016 +0200| [eae359b159677237afc52a49fafcdbcf1bbf8ad1] | committer: Geoffrey Métais

Don't use attr color for textview background

> https://code.videolan.org/videolan/vlc-android/commit/eae359b159677237afc52a49fafcdbcf1bbf8ad1
---

 vlc-android/res/layout-v16/player_action_bar.xml | 5 ++---
 vlc-android/res/layout/player_action_bar.xml     | 9 ++++-----
 vlc-android/res/values/attrs.xml                 | 2 --
 vlc-android/res/values/styles.xml                | 2 --
 4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/vlc-android/res/layout-v16/player_action_bar.xml b/vlc-android/res/layout-v16/player_action_bar.xml
index 6ccc5c1..2c7fa37 100644
--- a/vlc-android/res/layout-v16/player_action_bar.xml
+++ b/vlc-android/res/layout-v16/player_action_bar.xml
@@ -11,9 +11,8 @@
         android:layout_weight="1"
         android:gravity="center"
         android:layout_gravity="top"
-        android:background="?attr/status_bar_overlay"
-        android:text="@string/title"
-        android:textColor="#ffffff"
+        android:background="@color/transparent"
+        android:textColor="@color/white"
         android:paddingLeft="5dp"
         android:paddingRight="5dp"
         android:textSize="15sp"
diff --git a/vlc-android/res/layout/player_action_bar.xml b/vlc-android/res/layout/player_action_bar.xml
index 87f92d0..36a62f5 100644
--- a/vlc-android/res/layout/player_action_bar.xml
+++ b/vlc-android/res/layout/player_action_bar.xml
@@ -4,7 +4,7 @@
     android:layout_width="fill_parent"
     android:layout_height="fill_parent"
     android:layout_alignParentTop="true"
-    android:background="?attr/video_player_overlay"
+    android:background="@color/transparent"
     android:paddingLeft="5dp"
     android:paddingRight="5dp" >
 
@@ -14,8 +14,7 @@
         android:layout_height="match_parent"
         android:layout_weight="1"
         android:gravity="center"
-        android:text="@string/title"
-        android:textColor="#ffffff"
+        android:textColor="@color/white"
         android:textSize="15sp" />
 
     <TextView
@@ -23,7 +22,7 @@
         android:layout_width="wrap_content"
         android:layout_height="match_parent"
         android:layout_marginRight="5dp"
-        android:textColor="#ffffff"
+        android:textColor="@color/white"
         android:textSize="15sp"
         android:gravity="center"
         tools:ignore="true" />
@@ -32,7 +31,7 @@
         android:id="@+id/player_overlay_systime"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:textColor="#ffffff"
+        android:textColor="@color/white"
         android:textSize="15sp"
         tools:ignore="true" />
 
diff --git a/vlc-android/res/values/attrs.xml b/vlc-android/res/values/attrs.xml
index 338b5e0..5388db7 100644
--- a/vlc-android/res/values/attrs.xml
+++ b/vlc-android/res/values/attrs.xml
@@ -16,8 +16,6 @@
     <attr name="font_actionbar" format="reference|color" />
     <attr name="font_actionbar_selected" format="reference|color" />
     <attr name="navigationview_item_color" format="reference|color" />
-    <attr name="video_player_overlay" format="reference|color" />
-    <attr name="status_bar_overlay" format="reference|color" />
     <attr name="advanced_options_divider" format="reference|color" />
     <attr name="advanced_options_background" format="reference|color" />
     <attr name="audio_browser_separator" format="reference|color" />
diff --git a/vlc-android/res/values/styles.xml b/vlc-android/res/values/styles.xml
index 0aa73d0..2dd16e5 100644
--- a/vlc-android/res/values/styles.xml
+++ b/vlc-android/res/values/styles.xml
@@ -195,8 +195,6 @@
         <item name="android:windowFullscreen">true</item>
         <item name="android:windowBackground">@color/black</item>
         <item name="windowActionBarOverlay">true</item>
-        <item name="video_player_overlay">@color/transparent</item>
-        <item name="status_bar_overlay">@color/transparent</item>
 
         <item name="colorPrimary">@color/orange800</item>
         <item name="colorPrimaryDark">@color/transparent</item>



More information about the Android mailing list