[Android] dialog: fix double DeleteGlobalRef

Thomas Guillem git at videolan.org
Wed Jun 22 16:03:29 CEST 2016


vlc-android | branch: master | Thomas Guillem <thomas at gllm.fr> | Wed Jun 22 15:59:40 2016 +0200| [b9a1f794e65527f5f95f4c1b99a1048305705a62] | committer: Thomas Guillem

dialog: fix double DeleteGlobalRef

cancel_cb cause nativeDismiss to be called that will call DeleteGlobalRef().

> https://code.videolan.org/videolan/vlc-android/commit/b9a1f794e65527f5f95f4c1b99a1048305705a62
---

 libvlc/jni/libvlcjni-dialog.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libvlc/jni/libvlcjni-dialog.c b/libvlc/jni/libvlcjni-dialog.c
index d99dd80..aa2057b 100644
--- a/libvlc/jni/libvlcjni-dialog.c
+++ b/libvlc/jni/libvlcjni-dialog.c
@@ -128,8 +128,6 @@ cancel_cb(void *p_data, libvlc_dialog_id *p_id)
 
     (*env)->CallStaticVoidMethod(env, fields.Dialog.clazz,
         fields.Dialog.cancelFromNativeID, jdialog);
-
-    (*env)->DeleteGlobalRef(env, jdialog);
 }
 
 static void



More information about the Android mailing list