[Android] [PATCH] Get cover art also for upnp network media

Marc K. morckx at gmail.com
Mon Nov 7 00:04:48 CET 2016


Hi Filip,

On Sun, 2016-11-06 at 18:22 +0100, Filip Roséen wrote:
> 
> Given that HttpImageLoader.downloadBitmap can return null to signal
> an error, the above suffers from a potential null-pointer-exception.
> I think it is more appropriate to handle such case gracefully, than
> to rely on something higher in the stack to catch the exception
> (potentially on the expense of alternative handlers not having the
> opportunity to kick in).
> 
OK, I had the impression that rather not catching anything was the
convention here ;)

Shall I send the revised patch via reply or as a new mail?

Marc


More information about the Android mailing list