[Android] [PATCH] Get cover art also for upnp network media

Filip Roséen filip at atch.se
Mon Nov 7 00:38:48 CET 2016


Hi Marc,

It is advised to not *copy+paste* patches directly into your email
client since it might format the patch wrong (which is what happened
for the patch in which this email is a reply to.

The lines have been wrapped, causing the patch to be ill-formed, as
can be easily recognized by following the below link:

 - https://patches.videolan.org/patch/14941/

On 2016-11-07 00:32, Marc K. wrote:

> Previously, cover art of upnp media was only shown in the browser, but
> not in the player.
> 
> Signed-off-by: Marc K <morckx at gmail.com>
> ---
>  .../src/org/videolan/vlc/gui/helpers/AudioUtil.java  | 20
> ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/vlc-
> android/src/org/videolan/vlc/gui/helpers/AudioUtil.java b/vlc-
> android/src/org/videolan/vlc/gui/helpers/AudioUtil.java
> index 846f996..6dd2fb0 100644
> --- a/vlc-android/src/org/videolan/vlc/gui/helpers/AudioUtil.java
> +++ b/vlc-android/src/org/videolan/vlc/gui/helpers/AudioUtil.java
> @@ -42,11 +42,13 @@ import org.videolan.vlc.R;
>  import org.videolan.vlc.VLCApplication;
>  import org.videolan.vlc.media.MediaUtils;
>  import org.videolan.vlc.util.AndroidDevices;
> +import org.videolan.vlc.util.HttpImageLoader;
>  import org.videolan.vlc.util.MurmurHash;
>  import org.videolan.vlc.util.Permissions;
>  import org.videolan.vlc.util.Util;
>  
>  import java.io.BufferedOutputStream;
> +import java.io.InputStream;
>  import java.io.File;
>  import java.io.FileOutputStream;
>  import java.io.FilenameFilter;
> @@ -227,6 +229,22 @@ public class AudioUtil {
>              }
>  
>              return artworkURL;
> +        } else if (artworkURL != null && artworkURL.startsWith("http:/
> /")) {
> +            try {
> +                /* Hack: The album art cannot actually be loaded
> synchronously via http.
> +                 * HttpImageLoader.downloadBitmap, however, will load
> it from the icons map
> +                 * if it was previously shown as thumbnail.
> +                 */
> +                Bitmap albumArt =
> HttpImageLoader.downloadBitmap(artworkURL);
> +                if (albumArt != null) {
> +                    File outputFile = File.createTempFile("cover-",
> ".jpg", context.getCacheDir());
> +                    FileOutputStream fos = new
> FileOutputStream(outputFile);
> +                    if (albumArt.compress(CompressFormat.JPEG, 90,
> fos))
> +                        return(outputFile.getPath());
> +                }
> +            } catch (IOException e) {
> +                e.printStackTrace();
> +            }
>          }
>          return null;
>      }
> @@ -322,8 +340,6 @@ public class AudioUtil {
>                  if (cacheFile.exists()) {
>                      if (cacheFile.length() > 0)
>                          coverPath = cachePath;
> -                    else
> -                        return null;
>                  }
>              }
>  
> -- 
> 2.9.3
> 
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20161107/eb36fa7b/attachment-0001.html>


More information about the Android mailing list