[Android] Background manager is already auto released

Geoffrey Métais git at videolan.org
Wed Jul 5 17:23:01 CEST 2017


vlc-android | branch: master | Geoffrey Métais <geoffrey.metais at gmail.com> | Wed Jul  5 14:41:59 2017 +0200| [69e32971ad4ed7bf9c4cd50e0a80f20ff38ffefa] | committer: Geoffrey Métais

Background manager is already auto released

> https://code.videolan.org/videolan/vlc-android/commit/69e32971ad4ed7bf9c4cd50e0a80f20ff38ffefa
---

 vlc-android/src/org/videolan/vlc/gui/tv/MainTvActivity.java         | 1 -
 .../src/org/videolan/vlc/gui/tv/MediaItemDetailsFragment.java       | 1 -
 .../org/videolan/vlc/gui/tv/browser/MediaLibBrowserFragment.java    | 6 ------
 .../src/org/videolan/vlc/gui/tv/browser/SortedBrowserFragment.java  | 6 ------
 4 files changed, 14 deletions(-)

diff --git a/vlc-android/src/org/videolan/vlc/gui/tv/MainTvActivity.java b/vlc-android/src/org/videolan/vlc/gui/tv/MainTvActivity.java
index bf5ad3e65..447024878 100644
--- a/vlc-android/src/org/videolan/vlc/gui/tv/MainTvActivity.java
+++ b/vlc-android/src/org/videolan/vlc/gui/tv/MainTvActivity.java
@@ -215,7 +215,6 @@ public class MainTvActivity extends BaseTvActivity implements OnItemViewSelected
                     RecommendationsService.class);
             startService(recommendationIntent);
         }
-        mBackgroundManager.release();
     }
 
     @Override
diff --git a/vlc-android/src/org/videolan/vlc/gui/tv/MediaItemDetailsFragment.java b/vlc-android/src/org/videolan/vlc/gui/tv/MediaItemDetailsFragment.java
index 869cc507c..20498acf0 100644
--- a/vlc-android/src/org/videolan/vlc/gui/tv/MediaItemDetailsFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/tv/MediaItemDetailsFragment.java
@@ -106,7 +106,6 @@ public class MediaItemDetailsFragment extends DetailsFragment implements Playbac
     @Override
     public void onDestroy() {
         super.onDestroy();
-        mBackgroundManager.release();
     }
 
     private void buildDetails() {
diff --git a/vlc-android/src/org/videolan/vlc/gui/tv/browser/MediaLibBrowserFragment.java b/vlc-android/src/org/videolan/vlc/gui/tv/browser/MediaLibBrowserFragment.java
index 1ee2a6593..9883d4e3e 100644
--- a/vlc-android/src/org/videolan/vlc/gui/tv/browser/MediaLibBrowserFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/tv/browser/MediaLibBrowserFragment.java
@@ -65,12 +65,6 @@ public abstract class MediaLibBrowserFragment extends GridFragment implements On
             TvUtil.updateBackground(mBackgroundManager, mSelectedItem);
     }
 
-    @Override
-    public void onStop() {
-        super.onStop();
-        mBackgroundManager.release();
-    }
-
     public void refresh() {
         if (!mMediaLibrary.isWorking())
             mMediaLibrary.reload();
diff --git a/vlc-android/src/org/videolan/vlc/gui/tv/browser/SortedBrowserFragment.java b/vlc-android/src/org/videolan/vlc/gui/tv/browser/SortedBrowserFragment.java
index 6e5bc74e2..43d66d947 100644
--- a/vlc-android/src/org/videolan/vlc/gui/tv/browser/SortedBrowserFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/tv/browser/SortedBrowserFragment.java
@@ -126,12 +126,6 @@ public abstract class SortedBrowserFragment extends BrowseFragment implements Br
     }
 
     @Override
-    public void onStop() {
-        super.onStop();
-        mBackgroundManager.release();
-    }
-
-    @Override
     public void onSaveInstanceState(Bundle outState) {
         super.onSaveInstanceState(outState);
         if (mItemSelected != null)



More information about the Android mailing list