[Android] [PATCH] Fix VerticalSeeBar background color problem with RTL

Habib Kazemi kazemihabib1996 at gmail.com
Tue Jun 6 10:07:52 CEST 2017


sorry but I couldn't understand your reply! because I forced "LTR"
direction here not "RTL"
It has problem with "RTL" so I forced "LTR" direction.
and I tried "locale" and it didn't fix the problem.

On Tue, Jun 6, 2017 at 12:21 PM, Geoffrey Métais <geoffrey at videolan.org>
wrote:

>
>
> Forcing RTL on a device, I don't see any improvement whit this setting.
> But maybe it's a firmware bug. This fix seems correct.
>
> But right now you are forcing RTL.
> This way, it breaks LTR support the same way as RTL is currently broken.
> android:layoutDirection="locale" seems more appropriate.
>
> Le lun. 5 juin 2017 à 11:37, habib kazemi <kazemihabib1996 at gmail.com> a
> écrit :
>
>> Fix #290
>> ---
>>  vlc-android/res/layout/equalizer_bar.xml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/vlc-android/res/layout/equalizer_bar.xml
>> b/vlc-android/res/layout/equalizer_bar.xml
>> index b83a8fb77..cc2469884 100644
>> --- a/vlc-android/res/layout/equalizer_bar.xml
>> +++ b/vlc-android/res/layout/equalizer_bar.xml
>> @@ -9,6 +9,7 @@
>>      <!-- Be careful: the view is rotated by 90 degrees. -->
>>      <org.videolan.vlc.gui.view.VerticalSeekBar
>>          android:id="@+id/equalizer_seek"
>> +        android:layoutDirection="ltr"
>>          android:layout_width="wrap_content"
>>          android:layout_height="0dp"
>>          android:layout_gravity="center_horizontal"
>> --
>> 2.13.0
>>
>> _______________________________________________
>> Android mailing list
>> Android at videolan.org
>> https://mailman.videolan.org/listinfo/android
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20170606/6166ef67/attachment.html>


More information about the Android mailing list