[Android] If folders are already specified, don't add external storage

[XilasZ]

This list is a user setting, the list of folders to scan, using it to store
external storage already discovered caused a regression : it is added/scan
at each startup, even if the storage is not a new one.

A specific list, different from user settings is required i think.

Le 12 mars 2017 22:11, "Geoffrey Métais" <geoffrey.metais at gmail.com> a
écrit :

> That's not a reason for a major regression.
> And if storage is removed, it won't appear in discovered storage list. I
> don't see the big
>
> Le dim. 12 mars 2017 à 20:00, XilasZ <xilasz at gmail.com> a écrit :
>
>> The issue was that vlc always discover external storage, even if the user
>> removed it from folders to scan.
>>
>> Le 12 mars 2017 13:04, "Geoffrey Métais" <geoffrey at videolan.org> a
>> écrit :
>>
>> In this case, VLC is not able to discover any new external storage.
>> I don't see the point of banning sdcards and USB keys.
>>
>> Le dim. 12 mars 2017 à 08:04, Sébastien Toque <git at videolan.org> a
>> écrit :
>>
>> vlc-android | branch: master | Sébastien Toque <xilasz at gmail.com> | Sun
>> Mar 12 08:02:19 2017 +0100| [b231b09e7ad99455d6e970b5f675a4fb1697827f] |
>> committer: Sébastien Toque
>>
>> If folders are already specified, don't add external storage
>>
>> > https://code.videolan.org/videolan/vlc-android/commit/
>> b231b09e7ad99455d6e970b5f675a4fb1697827f
>> ---
>>
>>  vlc-android/src/org/videolan/vlc/MediaParsingService.java | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/vlc-android/src/org/videolan/vlc/MediaParsingService.java
>> b/vlc-android/src/org/videolan/vlc/MediaParsingService.java
>> index 2ce2575..4fdcc47 100644
>> --- a/vlc-android/src/org/videolan/vlc/MediaParsingService.java
>> +++ b/vlc-android/src/org/videolan/vlc/MediaParsingService.java
>> @@ -132,7 +132,8 @@ public class MediaParsingService extends Service
>> implements DevicesDiscoveryCb {
>>                              mMedialibrary.forceParserRetry();
>>                          }
>>                          for (String externalStorage : AndroidDevices.
>> getExternalStorageDirectories()) {
>> -                            if (!TextUtils.equals(externalStorage,
>> AndroidDevices.EXTERNAL_PUBLIC_DIRECTORY)
>> +                            if (foldersList.length == 0
>> +                                    && !TextUtils.equals(externalStorage,
>> AndroidDevices.EXTERNAL_PUBLIC_DIRECTORY)
>>                                      && !Util.arrayContains(foldersList,
>> "file://" + externalStorage + "/")) {
>>                                  for (String folder :
>> Medialibrary.getBlackList())
>>                                      mMedialibrary.banFolder(externalStorage
>> + folder);
>>
>> _______________________________________________
>> Android mailing list
>> Android at videolan.org
>> https://mailman.videolan.org/listinfo/android
>>
>>
>> _______________________________________________
>> Android mailing list
>> Android at videolan.org
>> https://mailman.videolan.org/listinfo/android
>>
>> _______________________________________________
>> Android mailing list
>> Android at videolan.org
>> https://mailman.videolan.org/listinfo/android
>>
>
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20170313/f26a9983/attachment.html>