[Android] LibVLC: disable automatic DTS_HD

Thomas Guillem thomas at gllm.fr
Mon Mar 13 15:38:47 CET 2017



On Mon, Mar 13, 2017, at 14:52, Thomas Guillem wrote:
> vlc-android | branch: master | Thomas Guillem <thomas at gllm.fr> | Mon Mar
> 13 14:52:12 2017 +0100| [e199c90adcc11dd349b71664b85d68bab7600956] |
> committer: Thomas Guillem
> 
> LibVLC: disable automatic DTS_HD
> 
> See comment, DTS_HD should be enabled via a Settings.
> 
> > https://code.videolan.org/videolan/vlc-android/commit/e199c90adcc11dd349b71664b85d68bab7600956
> ---
> 
>  libvlc/src/org/videolan/libvlc/MediaPlayer.java | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libvlc/src/org/videolan/libvlc/MediaPlayer.java
> b/libvlc/src/org/videolan/libvlc/MediaPlayer.java
> index ce7aa7e..54b16cb 100644
> --- a/libvlc/src/org/videolan/libvlc/MediaPlayer.java
> +++ b/libvlc/src/org/videolan/libvlc/MediaPlayer.java
> @@ -403,7 +403,10 @@ public class MediaPlayer extends
> VLCObject<MediaPlayer.Event> {
>              case AudioFormat.ENCODING_E_AC3:
>              case 14 /* AudioFormat.ENCODING_DOLBY_TRUEHD */:
>              case AudioFormat.ENCODING_DTS:
> -            case AudioFormat.ENCODING_DTS_HD:
> +            /* Disable automatic DTS_HD support. Androids report that
> DTS_HD is supported on every
> +             * devices that support DTS even if they don't support
> DTS_HD.
> +             * case AudioFormat.ENCODING_DTS_HD:
> +             */

I removed this commit via a force push. This is not Android fault. I
have an audio device that reports DTS_HD capabilities on different
OS/system even if it's false.

We need to think about a more general way to fix this kind of issue.

>                  return true;
>              default:
>                  return false;
> 
> _______________________________________________
> Android mailing list
> Android at videolan.org
> https://mailman.videolan.org/listinfo/android


More information about the Android mailing list