[Android] Remove dead code

Geoffrey Métais git at videolan.org
Wed Apr 4 18:34:53 CEST 2018


vlc-android | branch: master | Geoffrey Métais <geoffrey.metais at gmail.com> | Fri Mar  2 16:24:50 2018 +0100| [53b1df42de917f788c70a55f882ddcf1f1b64402] | committer: Geoffrey Métais

Remove dead code

> https://code.videolan.org/videolan/vlc-android/commit/53b1df42de917f788c70a55f882ddcf1f1b64402
---

 vlc-android/src/org/videolan/vlc/gui/HistoryFragment.java      |  3 ---
 vlc-android/src/org/videolan/vlc/gui/MainActivity.java         |  2 --
 .../org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java   |  3 ---
 .../src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java   |  8 --------
 .../src/org/videolan/vlc/gui/browser/MediaBrowserFragment.java | 10 ----------
 .../src/org/videolan/vlc/gui/video/VideoGridFragment.java      |  3 ---
 6 files changed, 29 deletions(-)

diff --git a/vlc-android/src/org/videolan/vlc/gui/HistoryFragment.java b/vlc-android/src/org/videolan/vlc/gui/HistoryFragment.java
index bf234adc4..f281bc841 100644
--- a/vlc-android/src/org/videolan/vlc/gui/HistoryFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/HistoryFragment.java
@@ -131,9 +131,6 @@ public class HistoryFragment extends MediaBrowserFragment implements IRefreshabl
         refresh();
     }
 
-    @Override
-    public void display() {}
-
     @Override
     public String getTitle() {
         return getString(R.string.history);
diff --git a/vlc-android/src/org/videolan/vlc/gui/MainActivity.java b/vlc-android/src/org/videolan/vlc/gui/MainActivity.java
index c84d5518a..0f33bd462 100644
--- a/vlc-android/src/org/videolan/vlc/gui/MainActivity.java
+++ b/vlc-android/src/org/videolan/vlc/gui/MainActivity.java
@@ -158,8 +158,6 @@ public class MainActivity extends ContentActivity implements FilterQueryProvider
             public void onDrawerClosed(View drawerView) {
                 super.onDrawerClosed(drawerView);
                 final Fragment current = getCurrentFragment();
-                if (current instanceof MediaBrowserFragment)
-                    ((MediaBrowserFragment) current).setReadyToDisplay(true);
             }
 
             // Hack to make navigation drawer browsable with DPAD.
diff --git a/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java b/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java
index 5590387ca..ee7c9c728 100644
--- a/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.java
@@ -96,9 +96,6 @@ public class AudioAlbumsSongsFragment extends BaseAudioBrowser implements SwipeR
                             getArguments().getParcelable(AudioBrowserFragment.TAG_ITEM));
     }
 
-    @Override
-    protected void display() {}
-
     @Override
     public String getTitle() {
         return mItem.getTitle();
diff --git a/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java b/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java
index bdb2bdf93..d7dd60a22 100644
--- a/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.java
@@ -379,14 +379,6 @@ public class AudioBrowserFragment extends BaseAudioBrowser implements SwipeRefre
         VLCApplication.getAppContext().startService(new Intent(Constants.ACTION_RELOAD, null, VLCApplication.getAppContext(), MediaParsingService.class));
     }
 
-    @Override
-    public void setReadyToDisplay(boolean ready) {
-            mReadyToDisplay = ready;
-    }
-
-    @Override
-    public void display() {}
-
     @Override
     public String getTitle() {
         return getString(R.string.audio);
diff --git a/vlc-android/src/org/videolan/vlc/gui/browser/MediaBrowserFragment.java b/vlc-android/src/org/videolan/vlc/gui/browser/MediaBrowserFragment.java
index 489ce3173..dce2453f4 100644
--- a/vlc-android/src/org/videolan/vlc/gui/browser/MediaBrowserFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/browser/MediaBrowserFragment.java
@@ -67,7 +67,6 @@ public abstract class MediaBrowserFragment extends PlaybackServiceFragment imple
     public final static String TAG = "VLC/MediaBrowserFragment";
 
     protected SwipeRefreshLayout mSwipeRefreshLayout;
-    protected volatile boolean mReadyToDisplay = true;
     protected Medialibrary mMediaLibrary;
     protected ActionMode mActionMode;
     public FloatingActionButton mFabPlay;
@@ -141,20 +140,11 @@ public abstract class MediaBrowserFragment extends PlaybackServiceFragment imple
 
     public void onFabPlayClick(View view) {}
 
-    public void setReadyToDisplay(boolean ready) {
-        if (ready && !mReadyToDisplay)
-            display();
-        else
-            mReadyToDisplay = ready;
-    }
-
-
     public abstract String getTitle();
     public abstract void onRefresh();
 
     protected String getSubTitle() { return null; }
     public void clear() {}
-    protected void display() {}
 
     protected void inflate(Menu menu, int position) {}
     protected void setContextMenuItems(Menu menu, int position) {}
diff --git a/vlc-android/src/org/videolan/vlc/gui/video/VideoGridFragment.java b/vlc-android/src/org/videolan/vlc/gui/video/VideoGridFragment.java
index 2d3c43a25..8c584f408 100644
--- a/vlc-android/src/org/videolan/vlc/gui/video/VideoGridFragment.java
+++ b/vlc-android/src/org/videolan/vlc/gui/video/VideoGridFragment.java
@@ -341,9 +341,6 @@ public class VideoGridFragment extends MediaBrowserFragment implements SwipeRefr
         getActivity().startService(new Intent(Constants.ACTION_RELOAD, null, getActivity(), MediaParsingService.class));
     }
 
-    @Override
-    public void display() {}
-
     public void clear(){
         mAdapter.clear();
     }



More information about the Android mailing list