[Android] Selection color in all the row
Brais Gabín
git at videolan.org
Mon Jan 7 17:36:14 CET 2019
vlc-android | branch: master | Brais Gabín <braisgabin at gmail.com> | Sun Jan 6 17:10:59 2019 +0100| [0f55cbd69e5ef08d4a45fa8192dd4b973b1d6147] | committer: Geoffrey Métais
Selection color in all the row
Signed-off-by: Geoffrey Métais <geoffrey.metais at gmail.com>
> https://code.videolan.org/videolan/vlc-android/commit/0f55cbd69e5ef08d4a45fa8192dd4b973b1d6147
---
vlc-android/res/layout-v21/audio_recyclerview.xml | 2 --
vlc-android/res/layout/audio_browser_item.xml | 9 ++++++++-
vlc-android/res/layout/audio_recyclerview.xml | 2 --
vlc-android/res/values-sw480dp/dimens.xml | 2 ++
vlc-android/res/values/dimens.xml | 2 ++
5 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/vlc-android/res/layout-v21/audio_recyclerview.xml b/vlc-android/res/layout-v21/audio_recyclerview.xml
index 2ed0ebdf3..a67dc5eed 100644
--- a/vlc-android/res/layout-v21/audio_recyclerview.xml
+++ b/vlc-android/res/layout-v21/audio_recyclerview.xml
@@ -5,8 +5,6 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
- android:paddingLeft="20dp"
- android:paddingRight="20dp"
app:fastScrollEnabled="true"
app:fastScrollHorizontalThumbDrawable="@drawable/fastscroll_thumb_drawable"
app:fastScrollHorizontalTrackDrawable="@drawable/fastscroll_track_drawable"
diff --git a/vlc-android/res/layout/audio_browser_item.xml b/vlc-android/res/layout/audio_browser_item.xml
index 320f4a6b3..e92c3c767 100644
--- a/vlc-android/res/layout/audio_browser_item.xml
+++ b/vlc-android/res/layout/audio_browser_item.xml
@@ -40,7 +40,10 @@
android:id="@+id/section_header"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:padding="8dp"
+ android:paddingLeft="28dp"
+ android:paddingTop="8dp"
+ android:paddingRight="28dp"
+ android:paddingBottom="8dp"
vlc:layout_constraintTop_toTopOf="parent"
android:singleLine="true"
android:text="@{header}"
@@ -54,6 +57,7 @@
android:id="@+id/media_cover"
android:layout_height="@dimen/audio_browser_item_size"
android:layout_width="0dp"
+ android:layout_marginStart="20dp"
vlc:layout_constraintDimensionRatio="1"
vlc:layout_constraintTop_toBottomOf="@+id/section_header"
vlc:layout_constraintStart_toStartOf="parent"
@@ -71,6 +75,8 @@
android:id="@+id/title"
android:layout_width="0dp"
android:layout_height="wrap_content"
+ vlc:layout_goneMarginStart="@dimen/default_margin_plus_audio_margin"
+ vlc:layout_goneMarginEnd="@dimen/default_margin_plus_audio_margin"
vlc:layout_constraintVertical_chainStyle="packed"
vlc:layout_constraintTop_toBottomOf="@+id/section_header"
vlc:layout_constraintStart_toEndOf="@+id/media_cover"
@@ -98,6 +104,7 @@
android:id="@+id/item_more"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
+ android:layout_marginEnd="20dp"
vlc:layout_constraintEnd_toEndOf="parent"
vlc:layout_constraintTop_toTopOf="@+id/title"
vlc:layout_constraintBottom_toBottomOf="@+id/subtitle"
diff --git a/vlc-android/res/layout/audio_recyclerview.xml b/vlc-android/res/layout/audio_recyclerview.xml
index 0dcadf36b..a939c2170 100644
--- a/vlc-android/res/layout/audio_recyclerview.xml
+++ b/vlc-android/res/layout/audio_recyclerview.xml
@@ -3,6 +3,4 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
- android:paddingLeft="20dp"
- android:paddingRight="20dp"
android:background="?attr/background_default" />
\ No newline at end of file
diff --git a/vlc-android/res/values-sw480dp/dimens.xml b/vlc-android/res/values-sw480dp/dimens.xml
index 59e1d6764..5e1cfd901 100644
--- a/vlc-android/res/values-sw480dp/dimens.xml
+++ b/vlc-android/res/values-sw480dp/dimens.xml
@@ -9,4 +9,6 @@
<dimen name="default_margin">16dp</dimen>
<dimen name="half_default_margin">8dp</dimen>
<dimen name="info_progress_end_margin">64dp</dimen>
+
+ <dimen name="default_margin_plus_audio_margin">36dp</dimen>
</resources>
\ No newline at end of file
diff --git a/vlc-android/res/values/dimens.xml b/vlc-android/res/values/dimens.xml
index 76fc63df1..afa8b917d 100644
--- a/vlc-android/res/values/dimens.xml
+++ b/vlc-android/res/values/dimens.xml
@@ -85,4 +85,6 @@
<dimen name="subs_dl_dialog_width">320dp</dimen>
<dimen name="subs_dl_dialog_height">170dp</dimen>
<dimen name="player_option_width">224dp</dimen>
+
+ <dimen name="default_margin_plus_audio_margin">28dp</dimen>
</resources>
\ No newline at end of file
More information about the Android
mailing list