[Android] AudioPlayer: increase margins in landscape

Geoffrey Métais git at videolan.org
Wed Jul 10 10:31:17 CEST 2019


vlc-android | branch: master | Geoffrey Métais <geoffrey.metais at gmail.com> | Wed Jul 10 10:30:42 2019 +0200| [f4967f80d761b4218bb9e93269995d2926697966] | committer: Geoffrey Métais

AudioPlayer: increase margins in landscape

> https://code.videolan.org/videolan/vlc-android/commit/f4967f80d761b4218bb9e93269995d2926697966
---

 vlc-android/res/layout-land/audio_player.xml | 4 +---
 vlc-android/res/layout/audio_player.xml      | 7 ++-----
 vlc-android/res/values/dimens.xml            | 2 +-
 3 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/vlc-android/res/layout-land/audio_player.xml b/vlc-android/res/layout-land/audio_player.xml
index ba69c71a3..91bcb113d 100644
--- a/vlc-android/res/layout-land/audio_player.xml
+++ b/vlc-android/res/layout-land/audio_player.xml
@@ -211,9 +211,7 @@
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintEnd_toStartOf="@+id/songs_list"
             app:layout_constraintBottom_toTopOf="@+id/play_pause"
-            android:layout_marginLeft="@dimen/audio_player_cover_margin"
-            android:layout_marginRight="@dimen/audio_player_cover_margin"
-            android:layout_marginTop="@dimen/audio_player_cover_margin"
+            android:layout_margin="@dimen/audio_player_cover_margin"
             android:visibility="visible"
             tools:layout_constraintLeft_creator="1" />
 
diff --git a/vlc-android/res/layout/audio_player.xml b/vlc-android/res/layout/audio_player.xml
index ce7cba345..5ddfc5b89 100644
--- a/vlc-android/res/layout/audio_player.xml
+++ b/vlc-android/res/layout/audio_player.xml
@@ -198,7 +198,7 @@
             android:visibility="@{showCover ? View.GONE : View.VISIBLE}"
             android:layout_gravity="center_horizontal"
             android:background="?attr/background_default"
-            android:layout_marginBottom="8dp"
+            android:layout_marginBottom="@dimen/audio_player_cover_margin"
             android:paddingBottom="@dimen/listview_bottom_padding" />
 
         <org.videolan.vlc.gui.view.CoverMediaSwitcher
@@ -210,10 +210,7 @@
             app:layout_constraintRight_toRightOf="parent"
             app:layout_constraintTop_toBottomOf="@+id/header"
             app:layout_constraintBottom_toTopOf="@+id/play_pause"
-            android:layout_marginLeft="@dimen/audio_player_cover_margin"
-            android:layout_marginRight="@dimen/audio_player_cover_margin"
-            android:layout_marginTop="@dimen/audio_player_cover_margin"
-            android:layout_marginBottom="@dimen/audio_player_cover_margin"
+            android:layout_margin="@dimen/audio_player_cover_margin"
             android:visibility="@{showCover ? View.VISIBLE : View.GONE}"
             tools:layout_constraintLeft_creator="1" />
 
diff --git a/vlc-android/res/values/dimens.xml b/vlc-android/res/values/dimens.xml
index f71b332ee..7be8ecea4 100644
--- a/vlc-android/res/values/dimens.xml
+++ b/vlc-android/res/values/dimens.xml
@@ -79,7 +79,7 @@
     <dimen name="fastscroller_track_height">30dp</dimen>
     <dimen name="fastscroller_track_width">6dp</dimen>
     <dimen name="fastscroller_track_padding">5dp</dimen>
-    <dimen name="audio_player_cover_margin">4dp</dimen>
+    <dimen name="audio_player_cover_margin">8dp</dimen>
     <dimen name="audio_player_elevation">16dp</dimen>
     <dimen name="progress_layout_height">24dp</dimen>
     <dimen name="dialog_sd_wisard_width">320dp</dimen>



More information about the Android mailing list