[Android] Fix white on white issue in audio cards

Nicolas Pomepuy git at videolan.org
Fri Jul 26 11:08:19 CEST 2019


vlc-android | branch: master | Nicolas Pomepuy <nicolas.pomepuy at gmail.com> | Thu Jul 25 11:41:39 2019 +0200| [e1e55aa6ce1da17465f8ff72ceeb4d3fa3987852] | committer: Nicolas Pomepuy

Fix white on white issue in audio cards

> https://code.videolan.org/videolan/vlc-android/commit/e1e55aa6ce1da17465f8ff72ceeb4d3fa3987852
---

 vlc-android/res/layout/audio_browser_card_item.xml | 1 +
 vlc-android/res/values/attrs.xml                   | 1 +
 vlc-android/res/values/styles.xml                  | 2 ++
 3 files changed, 4 insertions(+)

diff --git a/vlc-android/res/layout/audio_browser_card_item.xml b/vlc-android/res/layout/audio_browser_card_item.xml
index 8b5c638b3..c3e964d91 100644
--- a/vlc-android/res/layout/audio_browser_card_item.xml
+++ b/vlc-android/res/layout/audio_browser_card_item.xml
@@ -68,6 +68,7 @@
                     android:layout_height="0dp"
                     android:layout_gravity="center"
                     android:src="@{cover}"
+                    android:background="?attr/card_background"
                     android:scaleType="@{scaleType}"
                     android:visibility="@{(item.getItemType() & (MediaLibraryItem.TYPE_ALBUM|MediaLibraryItem.TYPE_ARTIST|MediaLibraryItem.TYPE_MEDIA|MediaLibraryItem.TYPE_PLAYLIST)) != 0 ? View.VISIBLE : View.GONE, default=gone}"
                     tools:srcCompat="@tools:sample/avatars"
diff --git a/vlc-android/res/values/attrs.xml b/vlc-android/res/values/attrs.xml
index 4412082bd..84a0ab2db 100644
--- a/vlc-android/res/values/attrs.xml
+++ b/vlc-android/res/values/attrs.xml
@@ -33,6 +33,7 @@
     <attr name="progress_background" format="reference|color" />
     <attr name="progress_indeterminate_tint" format="reference|color" />
     <attr name="ariane_text_color" format="reference|color"/>
+    <attr name="card_background" format="color"/>
 
     <!--Main Icons-->
     <attr name="ic_down_style" format="reference" />
diff --git a/vlc-android/res/values/styles.xml b/vlc-android/res/values/styles.xml
index 71ed44698..21d2283f5 100644
--- a/vlc-android/res/values/styles.xml
+++ b/vlc-android/res/values/styles.xml
@@ -92,6 +92,7 @@
         <item name="progress_background">@color/grey400</item>
         <item name="ariane_text_color">@color/grey50</item>
         <item name="player_icon_color">@color/black</item>
+        <item name="card_background">@color/grey300</item>
     </style>
 
     <style name="Theme.VLC.PickerDialog" parent="Theme.MaterialComponents.Dialog">
@@ -196,6 +197,7 @@
         <item name="progress_background">@color/grey700</item>
         <item name="ariane_text_color">@color/grey50</item>
         <item name="player_icon_color">@color/white</item>
+        <item name="card_background">@color/grey900</item>
     </style>
 
     <style name="Theme.VLC.Onboarding" parent="Theme.VLC.Black">



More information about the Android mailing list