[Android] Title style improvement + seekbar redesign
Nicolas Pomepuy
git at videolan.org
Wed Jun 5 10:31:30 CEST 2019
vlc-android | branch: master | Nicolas Pomepuy <nicolas.pomepuy at gmail.com> | Tue Jun 4 15:56:28 2019 +0200| [bc34553bc2d9b694960f6d17ccb04b4aab4aed53] | committer: Geoffrey Métais
Title style improvement + seekbar redesign
> https://code.videolan.org/videolan/vlc-android/commit/bc34553bc2d9b694960f6d17ccb04b4aab4aed53
---
vlc-android/res/drawable-v21/po_seekbar.xml | 35 +++++++++++++++---------
vlc-android/res/drawable/po_seekbar.xml | 16 +++++++----
vlc-android/res/layout/dialog_playback_speed.xml | 1 -
vlc-android/res/layout/dialog_select_chapter.xml | 1 -
vlc-android/res/layout/dialog_time_picker.xml | 1 -
vlc-android/res/layout/equalizer.xml | 1 -
vlc-android/res/layout/equalizer_bar.xml | 1 +
vlc-android/res/values/styles.xml | 11 ++++----
8 files changed, 39 insertions(+), 28 deletions(-)
diff --git a/vlc-android/res/drawable-v21/po_seekbar.xml b/vlc-android/res/drawable-v21/po_seekbar.xml
index 3acfa6311..110b6701f 100644
--- a/vlc-android/res/drawable-v21/po_seekbar.xml
+++ b/vlc-android/res/drawable-v21/po_seekbar.xml
@@ -1,26 +1,35 @@
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
-
- <item android:id="@android:id/background">
- <shape>
+ <item
+ android:id="@android:id/background"
+ android:gravity="center_vertical|fill_horizontal">
+ <shape android:shape="rectangle">
+ <corners android:radius="1dp" />
+ <size android:height="2dp" />
<solid android:color="?attr/progress_background" />
</shape>
</item>
-
- <item android:id="@android:id/secondaryProgress">
+ <item
+ android:id="@android:id/secondaryProgress"
+ android:gravity="center_vertical|fill_horizontal">
<clip>
- <shape>
- <solid android:color="@color/grey400transparent" />
+ <shape android:shape="rectangle">
+ <corners android:radius="1dp" />
+ <size android:height="2dp" />
+ <solid android:color="?attr/progress_background" />
</shape>
</clip>
</item>
-
- <item android:id="@android:id/progress">
+ <item
+ android:id="@android:id/progress"
+ android:gravity="center_vertical|fill_horizontal">
<clip>
- <shape>
- <solid android:color="@color/orange500transparent" />
+ <shape android:shape="rectangle">
+ <corners android:radius="1dp" />
+ <size android:height="2dp" />
+ <solid android:color="@color/orange500" />
</shape>
</clip>
</item>
-
-</layer-list>
\ No newline at end of file
+</layer-list>
+
\ No newline at end of file
diff --git a/vlc-android/res/drawable/po_seekbar.xml b/vlc-android/res/drawable/po_seekbar.xml
index 40d760470..93ebe42d7 100644
--- a/vlc-android/res/drawable/po_seekbar.xml
+++ b/vlc-android/res/drawable/po_seekbar.xml
@@ -2,15 +2,21 @@
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
<item android:id="@android:id/background">
- <shape>
- <solid android:color="@color/grey400transparent" />
- </shape>
+ <clip>
+ <shape>
+ <solid android:color="@color/grey400" />
+ <corners android:radius="1dp" />
+ <size android:height="2dp" />
+ </shape>
+ </clip>
</item>
<item android:id="@android:id/secondaryProgress">
<clip>
<shape>
- <solid android:color="@color/grey400transparent" />
+ <solid android:color="@color/grey400" />
+ <corners android:radius="1dp" />
+ <size android:height="2dp" />
</shape>
</clip>
</item>
@@ -18,7 +24,7 @@
<item android:id="@android:id/progress">
<clip>
<shape>
- <solid android:color="@color/orange500transparent" />
+ <solid android:color="@color/orange500" />
</shape>
</clip>
</item>
diff --git a/vlc-android/res/layout/dialog_playback_speed.xml b/vlc-android/res/layout/dialog_playback_speed.xml
index 92f8e8fec..3e02af92e 100644
--- a/vlc-android/res/layout/dialog_playback_speed.xml
+++ b/vlc-android/res/layout/dialog_playback_speed.xml
@@ -15,7 +15,6 @@
android:layout_marginTop="8dp"
android:layout_weight="1"
android:text="@string/playback_speed"
- android:textStyle="bold"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
diff --git a/vlc-android/res/layout/dialog_select_chapter.xml b/vlc-android/res/layout/dialog_select_chapter.xml
index 84c16928b..57b675c48 100644
--- a/vlc-android/res/layout/dialog_select_chapter.xml
+++ b/vlc-android/res/layout/dialog_select_chapter.xml
@@ -19,7 +19,6 @@
android:layout_marginStart="8dp"
android:layout_marginTop="8dp"
android:text="@string/go_to_chapter"
- android:textSize="20sp"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
diff --git a/vlc-android/res/layout/dialog_time_picker.xml b/vlc-android/res/layout/dialog_time_picker.xml
index 3df46579f..3cb09a15b 100644
--- a/vlc-android/res/layout/dialog_time_picker.xml
+++ b/vlc-android/res/layout/dialog_time_picker.xml
@@ -20,7 +20,6 @@
android:layout_marginTop="8dp"
android:layout_marginEnd="16dp"
android:text="PickTimeText"
- android:textStyle="bold"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
diff --git a/vlc-android/res/layout/equalizer.xml b/vlc-android/res/layout/equalizer.xml
index 9b2150c31..f5a9d30e3 100644
--- a/vlc-android/res/layout/equalizer.xml
+++ b/vlc-android/res/layout/equalizer.xml
@@ -26,7 +26,6 @@
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:text="@string/equalizer"
- android:textStyle="bold"
app:layout_constraintEnd_toStartOf="@+id/equalizer_button"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
diff --git a/vlc-android/res/layout/equalizer_bar.xml b/vlc-android/res/layout/equalizer_bar.xml
index ebef5895a..8d21616ab 100644
--- a/vlc-android/res/layout/equalizer_bar.xml
+++ b/vlc-android/res/layout/equalizer_bar.xml
@@ -25,6 +25,7 @@
android:id="@+id/equalizer_seek"
android:layout_width="0dp"
android:layout_height="0dp"
+ android:progressDrawable="@drawable/po_seekbar"
android:splitTrack="false"
android:thumb="@drawable/seekbar_thumb" />
</org.videolan.vlc.gui.view.VerticalSeekBarContainer>
diff --git a/vlc-android/res/values/styles.xml b/vlc-android/res/values/styles.xml
index 5e9c242f0..0b580d174 100644
--- a/vlc-android/res/values/styles.xml
+++ b/vlc-android/res/values/styles.xml
@@ -93,7 +93,7 @@
<item name="ic_abrepeat_setb">@drawable/ic_abrepeat_setb</item>
<item name="ic_abrepeat_reset">@drawable/ic_abrepeat_reset</item>
<item name="ic_dial">@drawable/ic_dial</item>
- <item name="progress_background">@color/grey600transparent</item>
+ <item name="progress_background">@color/grey300</item>
</style>
<style name="Theme.VLC.PickerDialog" parent="Theme.MaterialComponents.Dialog">
@@ -198,8 +198,8 @@
<item name="ic_abrepeat_setb">@drawable/ic_abrepeat_setb_w</item>
<item name="ic_abrepeat_reset">@drawable/ic_abrepeat_reset_w</item>
<item name="ic_dial">@drawable/ic_dial_w</item>
- <item name="progress_background">@color/grey400transparent</item>
<item name="progress_indeterminate_tint">@color/orange500</item>
+ <item name="progress_background">@color/grey700</item>
</style>
<style name="Theme.VLC.Onboarding" parent="Theme.VLC.Black">
@@ -328,7 +328,7 @@
<item name="list_subtitle">@color/grey400</item>
<item name="list_title_last">@color/list_title_last</item>
<item name="list_title">@color/bt_list_title</item>
- <item name="progress_background">@color/grey400transparent</item>
+ <item name="progress_background">@color/grey300</item>
<item name="ic_abrepeat">@drawable/ic_abrepeat_w</item>
<item name="ic_abrepeat_seta">@drawable/ic_abrepeat_seta_w</item>
<item name="ic_abrepeat_setb">@drawable/ic_abrepeat_setb_w</item>
@@ -487,9 +487,8 @@
<style name="Theme.VLC.BottomSheetTitle">
<item name="android:minHeight">56dp</item>
<item name="android:gravity">center_vertical</item>
- <item name="android:textColor">?attr/colorPrimary</item>
- <item name="android:textStyle">bold</item>
- <item name="android:textSize">16sp</item>
+ <item name="android:textColor">?attr/colorAccent</item>
+ <item name="android:textSize">18sp</item>
</style>
More information about the Android
mailing list