[Android] Fix tracks not scrollable in landscape

Nicolas Pomepuy git at videolan.org
Thu Aug 6 08:17:48 CEST 2020


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Aug  6 08:04:30 2020 +0200| [043dd8ca01cb885d3e18644f5dc738db04a32d5f] | committer: Nicolas Pomepuy

Fix tracks not scrollable in landscape

> https://code.videolan.org/videolan/vlc-android/commit/043dd8ca01cb885d3e18644f5dc738db04a32d5f
---

 .../res/layout-land/player_overlay_tracks.xml      | 103 +++++++++++----------
 1 file changed, 54 insertions(+), 49 deletions(-)

diff --git a/application/vlc-android/res/layout-land/player_overlay_tracks.xml b/application/vlc-android/res/layout-land/player_overlay_tracks.xml
index 5e9457c8d..fbb479610 100644
--- a/application/vlc-android/res/layout-land/player_overlay_tracks.xml
+++ b/application/vlc-android/res/layout-land/player_overlay_tracks.xml
@@ -31,60 +31,65 @@
 
     </data>
 
-    <androidx.constraintlayout.widget.ConstraintLayout
-            android:id="@+id/player_overlay_tracks"
+    <androidx.core.widget.NestedScrollView
             android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:orientation="horizontal">
+            android:layout_height="wrap_content">
 
-
-        <include
-                android:id="@+id/audio_tracks"
-                layout="@layout/player_overlay_track_item"
-                android:layout_width="0dp"
+        <androidx.constraintlayout.widget.ConstraintLayout
+                android:id="@+id/player_overlay_tracks"
+                android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                app:layout_constraintEnd_toStartOf="@+id/tracks_separator_2"
-                app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toTopOf="parent" />
+                android:orientation="horizontal">
 
-        <View
-                android:id="@+id/tracks_separator_2"
-                android:layout_width="1dp"
-                android:layout_height="0dp"
-                android:background="@color/white_transparent_10"
-                android:focusable="false"
-                app:layout_constraintBottom_toBottomOf="parent"
-                app:layout_constraintEnd_toStartOf="@+id/subtitle_tracks"
-                app:layout_constraintStart_toEndOf="@+id/audio_tracks"
-                app:layout_constraintTop_toTopOf="parent" />
 
-        <include
-                android:id="@+id/subtitle_tracks"
-                layout="@layout/player_overlay_track_item"
-                android:layout_width="0dp"
-                android:layout_height="wrap_content"
-                app:layout_constraintEnd_toStartOf="@+id/tracks_separator_3"
-                app:layout_constraintStart_toEndOf="@+id/tracks_separator_2"
-                app:layout_constraintTop_toTopOf="parent" />
+            <include
+                    android:id="@+id/audio_tracks"
+                    layout="@layout/player_overlay_track_item"
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    app:layout_constraintEnd_toStartOf="@+id/tracks_separator_2"
+                    app:layout_constraintStart_toStartOf="parent"
+                    app:layout_constraintTop_toTopOf="parent" />
 
-        <View
-                android:id="@+id/tracks_separator_3"
-                android:layout_width="1dp"
-                android:layout_height="0dp"
-                android:background="@color/white_transparent_10"
-                android:focusable="false"
-                app:layout_constraintBottom_toBottomOf="parent"
-                app:layout_constraintEnd_toStartOf="@+id/video_tracks"
-                app:layout_constraintStart_toEndOf="@+id/subtitle_tracks"
-                app:layout_constraintTop_toTopOf="parent" />
+            <View
+                    android:id="@+id/tracks_separator_2"
+                    android:layout_width="1dp"
+                    android:layout_height="0dp"
+                    android:background="@color/white_transparent_10"
+                    android:focusable="false"
+                    app:layout_constraintBottom_toBottomOf="parent"
+                    app:layout_constraintEnd_toStartOf="@+id/subtitle_tracks"
+                    app:layout_constraintStart_toEndOf="@+id/audio_tracks"
+                    app:layout_constraintTop_toTopOf="parent" />
 
-        <include
-                android:id="@+id/video_tracks"
-                layout="@layout/player_overlay_track_item"
-                android:layout_width="0dp"
-                android:layout_height="wrap_content"
-                app:layout_constraintEnd_toEndOf="parent"
-                app:layout_constraintStart_toEndOf="@+id/tracks_separator_3"
-                app:layout_constraintTop_toTopOf="parent" />
-    </androidx.constraintlayout.widget.ConstraintLayout>
+            <include
+                    android:id="@+id/subtitle_tracks"
+                    layout="@layout/player_overlay_track_item"
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    app:layout_constraintEnd_toStartOf="@+id/tracks_separator_3"
+                    app:layout_constraintStart_toEndOf="@+id/tracks_separator_2"
+                    app:layout_constraintTop_toTopOf="parent" />
+
+            <View
+                    android:id="@+id/tracks_separator_3"
+                    android:layout_width="1dp"
+                    android:layout_height="0dp"
+                    android:background="@color/white_transparent_10"
+                    android:focusable="false"
+                    app:layout_constraintBottom_toBottomOf="parent"
+                    app:layout_constraintEnd_toStartOf="@+id/video_tracks"
+                    app:layout_constraintStart_toEndOf="@+id/subtitle_tracks"
+                    app:layout_constraintTop_toTopOf="parent" />
+
+            <include
+                    android:id="@+id/video_tracks"
+                    layout="@layout/player_overlay_track_item"
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    app:layout_constraintEnd_toEndOf="parent"
+                    app:layout_constraintStart_toEndOf="@+id/tracks_separator_3"
+                    app:layout_constraintTop_toTopOf="parent" />
+        </androidx.constraintlayout.widget.ConstraintLayout>
+    </androidx.core.widget.NestedScrollView>
 </layout>
\ No newline at end of file



More information about the Android mailing list