[Android] Improve video grid and list progress bars

Nicolas Pomepuy git at videolan.org
Fri Aug 7 11:02:46 CEST 2020


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Fri Aug  7 10:17:11 2020 +0200| [cb996a278df2304ba01f7e2213363945e5914797] | committer: Nicolas Pomepuy

Improve video grid and list progress bars

> https://code.videolan.org/videolan/vlc-android/commit/cb996a278df2304ba01f7e2213363945e5914797
---

 application/vlc-android/res/layout/video_grid_card.xml | 9 ++-------
 application/vlc-android/res/layout/video_list_card.xml | 7 +++----
 2 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/application/vlc-android/res/layout/video_grid_card.xml b/application/vlc-android/res/layout/video_grid_card.xml
index 9eb15ca81..1e83c3bb4 100644
--- a/application/vlc-android/res/layout/video_grid_card.xml
+++ b/application/vlc-android/res/layout/video_grid_card.xml
@@ -185,17 +185,12 @@
                     style="@style/Widget.AppCompat.ProgressBar.Horizontal"
                     android:layout_width="0dp"
                     android:layout_height="wrap_content"
-                    android:layout_marginBottom="2dp"
                     android:background="@color/transparent"
                     android:focusable="false"
                     android:indeterminate="false"
                     android:max="@{max}"
-                    android:maxHeight="2dip"
-                    android:minHeight="2dip"
-                    android:paddingStart="@dimen/half_default_margin"
-                    android:paddingLeft="@dimen/half_default_margin"
-                    android:paddingEnd="@dimen/half_default_margin"
-                    android:paddingRight="@dimen/half_default_margin"
+                    android:maxHeight="4dip"
+                    android:minHeight="4dip"
                     android:progress="@{progress}"
                     android:progressDrawable="@drawable/gridview_progressbar"
                     android:secondaryProgress="0"
diff --git a/application/vlc-android/res/layout/video_list_card.xml b/application/vlc-android/res/layout/video_list_card.xml
index a01a2db20..8dd5cacc4 100644
--- a/application/vlc-android/res/layout/video_list_card.xml
+++ b/application/vlc-android/res/layout/video_list_card.xml
@@ -139,16 +139,15 @@
                 style="@android:style/Widget.ProgressBar.Horizontal"
                 android:layout_width="0dp"
                 android:layout_height="3dp"
-                android:background="@color/black"
                 vlc:layout_constraintStart_toStartOf="@+id/ml_item_thumbnail"
                 vlc:layout_constraintBottom_toBottomOf="@+id/ml_item_thumbnail"
                 vlc:layout_constraintEnd_toEndOf="@+id/ml_item_thumbnail"
                 android:indeterminate="false"
                 android:max="@{max}"
-                android:maxHeight="1dip"
-                android:minHeight="1dip"
+                android:maxHeight="2dip"
+                android:minHeight="2dip"
                 android:progress="@{progress}"
-                android:secondaryProgress="@{max}"
+                android:secondaryProgress="0"
                 android:progressDrawable="?attr/gridview_progressbar"
                 android:visibility="@{max == 0 ? View.INVISIBLE : View.VISIBLE}" />
     </androidx.constraintlayout.widget.ConstraintLayout>



More information about the Android mailing list