[Android] Video stats icon and text update

Nicolas Pomepuy git at videolan.org
Thu Jan 16 09:36:50 CET 2020


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Jan 16 09:24:54 2020 +0100| [1e526c9e41685d3a5f4d2ac47b35c83bb98f2c4f] | committer: Geoffrey Métais

Video stats icon and text update

> https://code.videolan.org/videolan/vlc-android/commit/1e526c9e41685d3a5f4d2ac47b35c83bb98f2c4f
---

 resources/src/main/res/values/strings.xml          |  2 +-
 vlc-android/res/drawable/ic_video_stats.xml        | 39 ++++++----------------
 vlc-android/res/layout/player_hud.xml              |  2 +-
 .../vlc/gui/helpers/PlayerOptionsDelegate.kt       |  2 +-
 4 files changed, 14 insertions(+), 31 deletions(-)

diff --git a/resources/src/main/res/values/strings.xml b/resources/src/main/res/values/strings.xml
index fe59d857b..4ef834d3f 100644
--- a/resources/src/main/res/values/strings.xml
+++ b/resources/src/main/res/values/strings.xml
@@ -782,7 +782,7 @@
     <string name="abrepeat_add_second_marker">Set end point</string>
     <string name="demux_bitrate">Demux bitrate</string>
     <string name="input_bitrate">Input bitrate</string>
-    <string name="video_stats">Video stats</string>
+    <string name="video_information">Video information</string>
 
     <string name="channels">Channels</string>
     <string name="resolution">Resolution</string>
diff --git a/vlc-android/res/drawable/ic_video_stats.xml b/vlc-android/res/drawable/ic_video_stats.xml
index edb8b2aad..6a263d7e8 100644
--- a/vlc-android/res/drawable/ic_video_stats.xml
+++ b/vlc-android/res/drawable/ic_video_stats.xml
@@ -1,33 +1,16 @@
-<!--
-  ~ *************************************************************************
-  ~  ic_video_stats.xml
-  ~ **************************************************************************
-  ~ Copyright © 2020 VLC authors and VideoLAN
-  ~ Author: Nicolas POMEPUY
-  ~ This program is free software; you can redistribute it and/or modify
-  ~ it under the terms of the GNU General Public License as published by
-  ~ the Free Software Foundation; either version 2 of the License, or
-  ~ (at your option) any later version.
-  ~
-  ~ This program is distributed in the hope that it will be useful,
-  ~ but WITHOUT ANY WARRANTY; without even the implied warranty of
-  ~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  ~ GNU General Public License for more details.
-  ~
-  ~ You should have received a copy of the GNU General Public License
-  ~ along with this program; if not, write to the Free Software
-  ~ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
-  ~ ***************************************************************************
-  ~
-  ~
-  -->
-
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
         android:width="36dp"
         android:height="36dp"
-        android:viewportWidth="24.0"
-        android:viewportHeight="24.0">
+        android:viewportWidth="36"
+        android:viewportHeight="36">
     <path
-            android:fillColor="?attr/player_icon_color"
-            android:pathData="M16,6l2.29,2.29 -4.88,4.88 -4,-4L2,16.59 3.41,18l6,-6 4,4 6.3,-6.29L22,12V6z" />
+            android:fillAlpha="1"
+            android:fillColor="#fafafa"
+            android:fillType="nonZero"
+            android:pathData="m18,6c-6.6274,0 -12,5.3726 -12,12 0,6.6275 5.3726,12 12,12 6.6274,0 12,-5.3725 12,-12 0,-6.6274 -5.3726,-12 -12,-12zM18,9c4.9706,0 9,4.0295 9,9 0,4.9706 -4.0294,9 -9,9 -4.9706,0 -9,-4.0294 -9,-9 0,-4.9705 4.0294,-9 9,-9zM16.5,12v3h3v-3zM16.5,16.5v7.5h3v-7.5z"
+            android:strokeWidth="15"
+            android:strokeAlpha="1"
+            android:strokeColor="#00000000"
+            android:strokeLineCap="round"
+            android:strokeLineJoin="round" />
 </vector>
diff --git a/vlc-android/res/layout/player_hud.xml b/vlc-android/res/layout/player_hud.xml
index 7812429b3..62cb8d98d 100644
--- a/vlc-android/res/layout/player_hud.xml
+++ b/vlc-android/res/layout/player_hud.xml
@@ -91,7 +91,7 @@
                                 vlc:layout_constraintTop_toTopOf="parent"
                                 vlc:layout_constraintStart_toStartOf="parent"
                                 vlc:layout_constraintEnd_toEndOf="parent"
-                                android:text="@string/video_stats" />
+                                android:text="@string/video_information" />
 
                         <org.videolan.liveplotgraph.PlotView
                                 android:id="@+id/plotView"
diff --git a/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt b/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt
index ac89b4078..b1970efcb 100644
--- a/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt
+++ b/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt
@@ -117,7 +117,7 @@ class PlayerOptionsDelegate(val activity: AppCompatActivity, val service: Playba
                     if (service.canShuffle()) options.add(PlayerOption(playerOptionType, ID_SHUFFLE, R.drawable.ic_shuffle, res.getString(R.string.shuffle_title)))
                     val chaptersCount = service.getChapters(-1)?.size ?: 0
                     if (chaptersCount > 1) options.add(PlayerOption(playerOptionType, ID_CHAPTER_TITLE, R.attr.ic_chapter_normal_style, res.getString(R.string.go_to_chapter)))
-                    options.add(PlayerOption(playerOptionType, ID_VIDEO_STATS, R.attr.ic_video_stats, res.getString(R.string.video_stats)))
+                    options.add(PlayerOption(playerOptionType, ID_VIDEO_STATS, R.attr.ic_video_stats, res.getString(R.string.video_information)))
                 }
                 options.add(PlayerOption(playerOptionType, ID_ABREPEAT, R.attr.ic_abrepeat, res.getString(R.string.ab_repeat)))
                 options.add(PlayerOption(playerOptionType, ID_SAVE_PLAYLIST, R.attr.ic_save, res.getString(R.string.playlist_save)))



More information about the Android mailing list