[Android] Fix bottomsheets crashing

Nicolas Pomepuy git at videolan.org
Thu May 7 12:17:03 CEST 2020


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon May  4 15:59:48 2020 +0200| [6fb5f0fdf4caa5a60a2e050455634ca76d46d3c4] | committer: Nicolas Pomepuy

Fix bottomsheets crashing

> https://code.videolan.org/videolan/vlc-android/commit/6fb5f0fdf4caa5a60a2e050455634ca76d46d3c4
---

 application/resources/src/main/res/drawable/bottom_sheet_background.xml | 2 +-
 application/resources/src/main/res/values/attrs.xml                     | 1 +
 application/vlc-android/res/values/styles.xml                           | 2 ++
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/application/resources/src/main/res/drawable/bottom_sheet_background.xml b/application/resources/src/main/res/drawable/bottom_sheet_background.xml
index 19a4c6ca5..cbd6ae2e2 100644
--- a/application/resources/src/main/res/drawable/bottom_sheet_background.xml
+++ b/application/resources/src/main/res/drawable/bottom_sheet_background.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android"
     android:shape="rectangle">
-    <solid android:color="?attr/bottom_navigation_background" />
+    <solid android:color="?attr/bottom_sheet_background" />
     <corners
         android:topLeftRadius="16dp"
         android:topRightRadius="16dp" />
diff --git a/application/resources/src/main/res/values/attrs.xml b/application/resources/src/main/res/values/attrs.xml
index ce661c73b..6a2e8475f 100644
--- a/application/resources/src/main/res/values/attrs.xml
+++ b/application/resources/src/main/res/values/attrs.xml
@@ -28,6 +28,7 @@
     <attr name="background_default" format="reference|color" />
     <attr name="header_background" format="reference|color" />
     <attr name="bottom_navigation_background" format="reference|color" />
+    <attr name="bottom_sheet_background" format="reference|color" />
     <attr name="bottom_navigation_color" format="reference|color" />
     <attr name="background_default_darker" format="reference|color" />
     <attr name="background_actionbar" format="reference|color" />
diff --git a/application/vlc-android/res/values/styles.xml b/application/vlc-android/res/values/styles.xml
index b642d6b30..25a0b9e4f 100644
--- a/application/vlc-android/res/values/styles.xml
+++ b/application/vlc-android/res/values/styles.xml
@@ -42,6 +42,7 @@
         <item name="item_footer">@color/grey300</item>
         <item name="background_default">@color/white</item>
         <item name="bottom_navigation_background">@drawable/bottom_navigation_background</item>
+        <item name="bottom_sheet_background">@color/white</item>
         <item name="bottom_navigation_color">@color/grey700</item>
         <item name="progress_indeterminate_tint">@color/white</item>
         <item name="header_background">@color/whitetransparent_ea</item>
@@ -168,6 +169,7 @@
         <item name="actionModeBackground">@color/grey875</item>
         <item name="background_default">@color/black</item>
         <item name="bottom_navigation_background">@drawable/bottom_navigation_background_dark</item>
+        <item name="bottom_sheet_background">@color/grey875</item>
         <item name="bottom_navigation_color">@color/grey500</item>
         <item name="header_background">@color/blacktransparent</item>
         <item name="background_default_darker">@color/grey875</item>



More information about the Android mailing list