[Android] Improve accessibility

Nicolas Pomepuy git at videolan.org
Tue Aug 3 08:17:13 UTC 2021


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Aug  2 09:24:53 2021 +0200| [6a0d43f3db7decbc4982cd29a5b98607697e7a2e] | committer: Nicolas Pomepuy

Improve accessibility

> https://code.videolan.org/videolan/vlc-android/commit/6a0d43f3db7decbc4982cd29a5b98607697e7a2e
---

 application/resources/src/main/res/values/strings.xml    | 2 ++
 application/vlc-android/res/layout-land/audio_player.xml | 4 ++--
 application/vlc-android/res/layout/audio_player.xml      | 4 ++--
 application/vlc-android/res/layout/player_hud.xml        | 2 +-
 application/vlc-android/res/layout/player_hud_right.xml  | 2 ++
 5 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index 1f5bd7a89..c471dce37 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -605,6 +605,8 @@
     <string name="otg_device_title">OTG device</string>
     <string name="browser">Browser</string>
     <string name="ab_repeat">A-B repeat</string>
+    <string name="ab_repeat_reset">Reset A-B repeat</string>
+    <string name="ab_repeat_stop">Stop A-B repeat</string>
     <string name="stop_after_this">Stop after this track</string>
     <string name="time_category_new">New media</string>
     <string name="time_category_current_month">This month</string>
diff --git a/application/vlc-android/res/layout-land/audio_player.xml b/application/vlc-android/res/layout-land/audio_player.xml
index d96c36c7a..dac6dce7c 100644
--- a/application/vlc-android/res/layout-land/audio_player.xml
+++ b/application/vlc-android/res/layout-land/audio_player.xml
@@ -188,7 +188,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_marginEnd="8dp"
-                    android:contentDescription="@string/search"
+                    android:contentDescription="@string/ab_repeat_reset"
                     android:focusable="true"
                     android:onClick="@{fragment::onABRepeatResetClick}"
                     android:padding="8dp"
@@ -204,7 +204,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_marginEnd="8dp"
-                    android:contentDescription="@string/search"
+                    android:contentDescription="@string/ab_repeat_stop"
                     android:focusable="true"
                     android:onClick="@{fragment::onABRepeatStopClick}"
                     android:padding="8dp"
diff --git a/application/vlc-android/res/layout/audio_player.xml b/application/vlc-android/res/layout/audio_player.xml
index 5f4c86691..4cdae2bdd 100644
--- a/application/vlc-android/res/layout/audio_player.xml
+++ b/application/vlc-android/res/layout/audio_player.xml
@@ -143,7 +143,7 @@
                     android:layout_height="wrap_content"
                     android:layout_marginEnd="8dp"
                     android:background="?attr/selectableItemBackgroundBorderless"
-                    android:contentDescription="@string/search"
+                    android:contentDescription="@string/ab_repeat_reset"
                     android:focusable="true"
                     android:onClick="@{fragment::onABRepeatResetClick}"
                     android:padding="8dp"
@@ -160,7 +160,7 @@
                     android:layout_height="wrap_content"
                     android:layout_marginEnd="8dp"
                     android:background="?attr/selectableItemBackgroundBorderless"
-                    android:contentDescription="@string/search"
+                    android:contentDescription="@string/ab_repeat_stop"
                     android:focusable="true"
                     android:onClick="@{fragment::onABRepeatStopClick}"
                     android:padding="8dp"
diff --git a/application/vlc-android/res/layout/player_hud.xml b/application/vlc-android/res/layout/player_hud.xml
index fb84c558e..416263ab7 100644
--- a/application/vlc-android/res/layout/player_hud.xml
+++ b/application/vlc-android/res/layout/player_hud.xml
@@ -477,7 +477,7 @@
                     android:layout_marginEnd="@dimen/small_margins_sides"
                     android:background="?attr/selectableItemBackgroundBorderless"
                     android:clickable="true"
-                    android:contentDescription="@string/advanced"
+                    android:contentDescription="@string/aspect_ratio"
                     android:focusable="true"
                     android:onClick="@{(v) -> player.resizeVideo()}"
                     android:scaleType="center"
diff --git a/application/vlc-android/res/layout/player_hud_right.xml b/application/vlc-android/res/layout/player_hud_right.xml
index 6a377d457..4ef71fd67 100644
--- a/application/vlc-android/res/layout/player_hud_right.xml
+++ b/application/vlc-android/res/layout/player_hud_right.xml
@@ -66,6 +66,7 @@
                 android:layout_marginTop="8dp"
                 android:layout_marginEnd="16dp"
                 android:background="?attr/selectableItemBackgroundBorderless"
+                android:contentDescription="@string/show_playlist"
                 android:focusable="true"
                 android:visibility="gone"
                 app:layout_constraintEnd_toEndOf="parent"
@@ -99,6 +100,7 @@
                 android:layout_marginTop="8dp"
                 android:layout_marginEnd="16dp"
                 android:background="?attr/selectableItemBackgroundBorderless"
+                android:contentDescription="@string/renderer_list_title"
                 android:focusable="true"
                 android:visibility="gone"
                 app:layout_constraintEnd_toStartOf="@+id/playlist_toggle"



More information about the Android mailing list