[Android] Fix browser / history spacing + add some info to history items

Nicolas Pomepuy git at videolan.org
Fri Jan 29 11:57:21 UTC 2021


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Fri Jan 29 11:54:30 2021 +0100| [173555db7ee876bdf5b8c7be04923dc8ce628a7b] | committer: Nicolas Pomepuy

Fix browser / history spacing + add some info to history items

Fixes #1622

> https://code.videolan.org/videolan/vlc-android/commit/173555db7ee876bdf5b8c7be04923dc8ce628a7b
---

 .../vlc-android/res/layout/browser_item.xml        |  4 ++--
 .../vlc-android/res/layout/history_item.xml        | 28 +++++++++++-----------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/application/vlc-android/res/layout/browser_item.xml b/application/vlc-android/res/layout/browser_item.xml
index 3ebe55afa..2b6c87a84 100644
--- a/application/vlc-android/res/layout/browser_item.xml
+++ b/application/vlc-android/res/layout/browser_item.xml
@@ -74,8 +74,8 @@
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginStart="12dp"
-                android:layout_marginTop="2dp"
-                android:layout_marginBottom="2dp"
+                android:layout_marginTop="4dp"
+                android:layout_marginBottom="4dp"
                 android:contentDescription="@string/cover_art"
                 android:onClick="@{holder::onImageClick}"
                 android:scaleType="centerCrop"
diff --git a/application/vlc-android/res/layout/history_item.xml b/application/vlc-android/res/layout/history_item.xml
index 3218acf5c..1cfbe4f95 100644
--- a/application/vlc-android/res/layout/history_item.xml
+++ b/application/vlc-android/res/layout/history_item.xml
@@ -38,26 +38,26 @@
             android:onLongClick="@{holder::onLongClick}">
 
         <androidx.constraintlayout.widget.ConstraintLayout
+                android:id="@+id/constraintLayout4"
                 android:layout_width="0dp"
+                android:layout_height="@dimen/audio_browser_item_size"
                 android:layout_marginStart="16dp"
-                android:layout_marginTop="8dp"
+                android:layout_marginTop="4dp"
+                android:layout_marginBottom="4dp"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintDimensionRatio="16:10"
                 app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toTopOf="parent"
-                android:layout_marginBottom="8dp"
-                android:layout_height="@dimen/audio_browser_item_size"
-                android:id="@+id/constraintLayout4">
+                app:layout_constraintTop_toTopOf="parent">
 
             <ImageView
+                    android:id="@+id/song_marker"
                     android:layout_width="0dp"
                     android:layout_height="0dp"
-                    app:srcCompat="@drawable/ic_no_song_vertical"
-                    android:id="@+id/song_marker"
+                    app:layout_constraintBottom_toBottomOf="parent"
                     app:layout_constraintEnd_toStartOf="@+id/icon"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintBottom_toBottomOf="parent"
-                    app:layout_constraintTop_toTopOf="parent" />
+                    app:layout_constraintTop_toTopOf="parent"
+                    app:srcCompat="@drawable/ic_no_song_vertical" />
 
             <ImageView
                     android:id="@+id/icon"
@@ -67,11 +67,11 @@
                     android:onClick="@{holder::onImageClick}"
                     android:scaleType="centerCrop"
                     android:src="@{cover}"
+                    app:layout_constraintBottom_toBottomOf="parent"
                     app:layout_constraintDimensionRatio="1"
+                    app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintTop_toTopOf="parent"
-                    app:layout_constraintBottom_toBottomOf="parent"
-                    app:media="@{media}"
-                    app:layout_constraintEnd_toEndOf="parent" />
+                    app:media="@{media}" />
         </androidx.constraintlayout.widget.ConstraintLayout>
 
 
@@ -95,8 +95,8 @@
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
                 android:layout_marginStart="16dp"
-                android:text="@{media.artist}"
-                android:visibility="@{TextUtils.isEmpty(media.artist) ? View.GONE : View.VISIBLE}"
+                android:text="@{media.description}"
+                android:visibility="@{TextUtils.isEmpty(media.description) ? View.GONE : View.VISIBLE}"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toEndOf="@+id/constraintLayout4"



More information about the Android mailing list