[Android] Improve bottom navigation ripple color

Nicolas Pomepuy git at videolan.org
Fri May 28 08:46:00 UTC 2021


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed May 26 08:20:51 2021 +0200| [36de02b8c1f67f3e6f70d27344696393da4eb85b] | committer: Nicolas Pomepuy

Improve bottom navigation ripple color

> https://code.videolan.org/videolan/vlc-android/commit/36de02b8c1f67f3e6f70d27344696393da4eb85b
---

 application/resources/src/main/res/values/attrs.xml  | 1 +
 application/resources/src/main/res/values/colors.xml | 3 +++
 application/vlc-android/res/layout/main.xml          | 2 +-
 application/vlc-android/res/values/styles.xml        | 2 ++
 4 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/application/resources/src/main/res/values/attrs.xml b/application/resources/src/main/res/values/attrs.xml
index 138bb3a83..b3b29b979 100644
--- a/application/resources/src/main/res/values/attrs.xml
+++ b/application/resources/src/main/res/values/attrs.xml
@@ -62,6 +62,7 @@
     <attr name="audio_chips_color" format="color" />
     <attr name="audio_chips_text_color" format="color" />
     <attr name="bookmark_background" format="color" />
+    <attr name="bottom_navigation_focus" format="color" />
 
     <!--Main Icons-->
     <attr name="ic_playlist" format="reference" />
diff --git a/application/resources/src/main/res/values/colors.xml b/application/resources/src/main/res/values/colors.xml
index 941ff6e51..1565c6fdb 100644
--- a/application/resources/src/main/res/values/colors.xml
+++ b/application/resources/src/main/res/values/colors.xml
@@ -90,12 +90,15 @@
     <color name="white_transparent_80">#ccffffff</color>
     <color name="white_transparent_90">#E6ffffff</color>
 
+    <color name="black_transparent_10">#1a000000</color>
     <color name="black_transparent_20">#33000000</color>
     <color name="black_transparent_50">#80000000</color>
     <color name="black_transparent_60">#99000000</color>
     <color name="black_transparent_75">#BF000000</color>
     <color name="black_transparent_80">#cc000000</color>
 
+    <color name="orange_800_transparent_10">#1aff610a</color>
+
     <color name="white_selection_transparent">#44ffffff</color>
 
     <color name="tv_bg">#3e6c80</color>
diff --git a/application/vlc-android/res/layout/main.xml b/application/vlc-android/res/layout/main.xml
index 87892e491..9819fe68c 100644
--- a/application/vlc-android/res/layout/main.xml
+++ b/application/vlc-android/res/layout/main.xml
@@ -58,7 +58,7 @@
             android:background="?attr/bottom_navigation_background"
             app:elevation="16dp"
             app:itemIconTint="@color/bottom_navigation_selector"
-            app:itemRippleColor="@color/orange500focus"
+            app:itemRippleColor="?attr/bottom_navigation_focus"
             app:itemTextColor="@color/bottom_navigation_selector"
             app:labelVisibilityMode="labeled"
             app:layout_behavior="org.videolan.vlc.gui.helpers.BottomNavigationBehavior"
diff --git a/application/vlc-android/res/values/styles.xml b/application/vlc-android/res/values/styles.xml
index e64cff977..746a6c131 100644
--- a/application/vlc-android/res/values/styles.xml
+++ b/application/vlc-android/res/values/styles.xml
@@ -68,6 +68,7 @@
         <item name="adv_options_item_background">@drawable/advanced_option_focusable_background</item>
         <item name="audio_chips_color">@color/black_transparent_75</item>
         <item name="audio_chips_text_color">@color/white_transparent_60</item>
+        <item name="bottom_navigation_focus">@color/orange_800_transparent_10</item>
 
         <item name="ic_playlist">@drawable/ic_playlist</item>
         <item name="ic_playlist_on">@drawable/ic_playlist_on</item>
@@ -212,6 +213,7 @@
         <item name="adv_options_item_background">@drawable/advanced_option_focusable_background_dark</item>
         <item name="audio_chips_color">@color/white_transparent_90</item>
         <item name="audio_chips_text_color">@color/black_transparent_60</item>
+        <item name="bottom_navigation_focus">@color/white_transparent_10</item>
 
         <item name="ic_playlist">@drawable/ic_playlist_w</item>
         <item name="ic_playlist_on">@drawable/ic_playlist_on</item>



More information about the Android mailing list