[Android] Video control settings: fix the scrolling issue

Nicolas Pomepuy git at videolan.org
Wed Nov 3 07:09:35 UTC 2021


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed Nov  3 07:38:00 2021 +0100| [51f96fef6811cf4f6849b32b36aa90114f12a65e] | committer: Nicolas Pomepuy

Video control settings: fix the scrolling issue

> https://code.videolan.org/videolan/vlc-android/commit/51f96fef6811cf4f6849b32b36aa90114f12a65e
---

 .../res/layout/dialog_video_controls_settings.xml  | 55 ++++++++++++----------
 1 file changed, 30 insertions(+), 25 deletions(-)

diff --git a/application/vlc-android/res/layout/dialog_video_controls_settings.xml b/application/vlc-android/res/layout/dialog_video_controls_settings.xml
index 358b2e0f6..b2073d9de 100644
--- a/application/vlc-android/res/layout/dialog_video_controls_settings.xml
+++ b/application/vlc-android/res/layout/dialog_video_controls_settings.xml
@@ -2,33 +2,38 @@
 <layout xmlns:android="http://schemas.android.com/apk/res/android"
         xmlns:app="http://schemas.android.com/apk/res-auto">
 
-    <androidx.constraintlayout.widget.ConstraintLayout
-            android:id="@+id/container"
+    <androidx.core.widget.NestedScrollView
             android:layout_width="match_parent"
-            android:layout_height="wrap_content">
+            android:layout_height="match_parent">
 
-        <TextView
-                android:id="@+id/video_controls_title"
-                style="@style/Theme.VLC.BottomSheetTitle"
-                android:layout_width="0dp"
-                android:layout_height="wrap_content"
-                android:layout_marginStart="16dp"
-                android:layout_marginTop="8dp"
-                android:layout_marginEnd="16dp"
-                android:text="@string/controls_setting"
-                app:layout_constraintEnd_toEndOf="parent"
-                app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toTopOf="parent" />
-
-        <androidx.fragment.app.FragmentContainerView
-                android:id="@+id/fragment_container_view"
-                android:name="org.videolan.vlc.gui.preferences.PreferencesVideoControls"
+        <androidx.constraintlayout.widget.ConstraintLayout
+                android:id="@+id/container"
                 android:layout_width="match_parent"
-                android:layout_height="0dp"
-                android:tag="my_tag"
-                app:layout_constraintEnd_toEndOf="parent"
-                app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toBottomOf="@id/video_controls_title" />
-    </androidx.constraintlayout.widget.ConstraintLayout>
+                android:layout_height="wrap_content">
+
+            <TextView
+                    android:id="@+id/video_controls_title"
+                    style="@style/Theme.VLC.BottomSheetTitle"
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    android:layout_marginStart="16dp"
+                    android:layout_marginTop="8dp"
+                    android:layout_marginEnd="16dp"
+                    android:text="@string/controls_setting"
+                    app:layout_constraintEnd_toEndOf="parent"
+                    app:layout_constraintStart_toStartOf="parent"
+                    app:layout_constraintTop_toTopOf="parent" />
+
+            <androidx.fragment.app.FragmentContainerView
+                    android:id="@+id/fragment_container_view"
+                    android:name="org.videolan.vlc.gui.preferences.PreferencesVideoControls"
+                    android:layout_width="match_parent"
+                    android:layout_height="0dp"
+                    android:tag="my_tag"
+                    app:layout_constraintEnd_toEndOf="parent"
+                    app:layout_constraintStart_toStartOf="parent"
+                    app:layout_constraintTop_toBottomOf="@id/video_controls_title" />
+        </androidx.constraintlayout.widget.ConstraintLayout>
+    </androidx.core.widget.NestedScrollView>
 
 </layout>



More information about the Android mailing list