[Android] Get rid of the old fast seek setting

Nicolas Pomepuy git at videolan.org
Wed Sep 1 11:44:41 UTC 2021


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed Sep  1 12:15:58 2021 +0200| [2c2b7ab56313c45a4a026662f8f08784567a3d97] | committer: Nicolas Pomepuy

Get rid of the old fast seek setting

> https://code.videolan.org/videolan/vlc-android/commit/2c2b7ab56313c45a4a026662f8f08784567a3d97
---

 .../java/org/videolan/vlc/gui/preferences/PreferencesVideoUITest.kt | 6 ------
 .../resources/src/main/java/org/videolan/resources/VLCOptions.kt    | 1 -
 application/resources/src/main/res/values/strings.xml               | 2 --
 application/vlc-android/res/xml/preferences_video.xml               | 6 ------
 4 files changed, 15 deletions(-)

diff --git a/application/app/src/androidTest/java/org/videolan/vlc/gui/preferences/PreferencesVideoUITest.kt b/application/app/src/androidTest/java/org/videolan/vlc/gui/preferences/PreferencesVideoUITest.kt
index 3ebb0b0a9..85fc7be0b 100644
--- a/application/app/src/androidTest/java/org/videolan/vlc/gui/preferences/PreferencesVideoUITest.kt
+++ b/application/app/src/androidTest/java/org/videolan/vlc/gui/preferences/PreferencesVideoUITest.kt
@@ -47,12 +47,6 @@ class PreferencesVideoUITest: BasePreferenceUITest() {
         checkToggleWorks(key, settings, default = false)
     }
 
-    @Test
-    fun checkFastSeekMediaSetting() {
-        val key = "media_fast_seek"
-        checkToggleWorks(key, settings)
-    }
-
     @Test
     fun checkVideoTitleOnTransitionSetting() {
         val key = "video_transition_show"
diff --git a/application/resources/src/main/java/org/videolan/resources/VLCOptions.kt b/application/resources/src/main/java/org/videolan/resources/VLCOptions.kt
index b01219d4b..8d740f449 100644
--- a/application/resources/src/main/java/org/videolan/resources/VLCOptions.kt
+++ b/application/resources/src/main/java/org/videolan/resources/VLCOptions.kt
@@ -222,7 +222,6 @@ object VLCOptions {
         if (noVideo) media.addOption(":no-video")
         if (paused) media.addOption(":start-paused")
         if (!prefs.getBoolean("subtitles_autoload", true)) media.addOption(":sub-language=none")
-        if (!benchmark && prefs.getBoolean("media_fast_seek", false)) media.addOption(":input-fast-seek")
 
         if (hasRenderer) {
             media.addOption(":sout-chromecast-audio-passthrough=" + prefs.getBoolean("casting_passthrough", true))
diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index d095dee9c..e2da8afd4 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -307,8 +307,6 @@
     <string name="video_min_group_length_disable">Do not group videos</string>
     <string name="video_min_group_length_folder">Group by folder</string>
     <string name="video_min_group_length_name">Group by name</string>
-    <string name="media_fast_seek">Fast seek</string>
-    <string name="media_fast_seek_summary">Seeking in a media is faster but less accurate</string>
     <string name="video_transition_title">Videos transition</string>
     <string name="video_transition_summary">Show new video title on transition</string>
     <string name="media_seen">Show seen video marker</string>
diff --git a/application/vlc-android/res/xml/preferences_video.xml b/application/vlc-android/res/xml/preferences_video.xml
index eeeda8194..7db509899 100644
--- a/application/vlc-android/res/xml/preferences_video.xml
+++ b/application/vlc-android/res/xml/preferences_video.xml
@@ -22,12 +22,6 @@
             android:key="playback_speed_video"
             android:summary="@string/playback_speed_summary"
             android:title="@string/playback_speed_title"/>
-    <CheckBoxPreference
-            app:singleLineTitle="false"
-            android:defaultValue="false"
-            android:key="media_fast_seek"
-            android:summary="@string/media_fast_seek_summary"
-            android:title="@string/media_fast_seek"/>
     <CheckBoxPreference
             app:singleLineTitle="false"
             android:defaultValue="true"



More information about the Android mailing list