[Android] Increase the more button size on all screens

Nicolas Pomepuy git at videolan.org
Mon Apr 4 08:34:59 UTC 2022


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Apr  4 08:09:22 2022 +0200| [a2222f9a495f054ddbe7ac961f5a46d48892841d] | committer: Nicolas Pomepuy

Increase the more button size on all screens

Fixes #2462

> https://code.videolan.org/videolan/vlc-android/commit/a2222f9a495f054ddbe7ac961f5a46d48892841d
---

 application/vlc-android/res/layout/audio_browser_item.xml | 4 +---
 application/vlc-android/res/layout/browser_item.xml       | 2 +-
 application/vlc-android/res/layout/mrl_item.xml           | 4 ++--
 application/vlc-android/res/layout/video_list_card.xml    | 6 +++---
 4 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/application/vlc-android/res/layout/audio_browser_item.xml b/application/vlc-android/res/layout/audio_browser_item.xml
index ba68367bf..88ab1757f 100644
--- a/application/vlc-android/res/layout/audio_browser_item.xml
+++ b/application/vlc-android/res/layout/audio_browser_item.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <layout xmlns:android="http://schemas.android.com/apk/res/android"
-        xmlns:tools="http://schemas.android.com/tools"
         xmlns:vlc="http://schemas.android.com/apk/res-auto">
 
     <data>
@@ -194,8 +193,7 @@
                 android:id="@+id/item_more"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:paddingEnd="8dp"
-                android:paddingStart="8dp"
+                android:padding="8dp"
                 android:contentDescription="@string/more_actions"
                 android:onClick="@{holder::onMoreClick}"
                 android:scaleType="center"
diff --git a/application/vlc-android/res/layout/browser_item.xml b/application/vlc-android/res/layout/browser_item.xml
index 940da065a..53bd3dfd9 100644
--- a/application/vlc-android/res/layout/browser_item.xml
+++ b/application/vlc-android/res/layout/browser_item.xml
@@ -156,10 +156,10 @@
                 android:id="@+id/item_more"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:layout_marginEnd="8dp"
                 android:background="?attr/selectableItemBackgroundBorderless"
                 android:clickable="@{hasContextMenu}"
                 android:onClick="@{holder::onMoreClick}"
+                android:padding="8dp"
                 android:visibility="@{hasContextMenu ? View.VISIBLE : View.GONE, default=gone}"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
diff --git a/application/vlc-android/res/layout/mrl_item.xml b/application/vlc-android/res/layout/mrl_item.xml
index 3f027abaf..2a91db78e 100644
--- a/application/vlc-android/res/layout/mrl_item.xml
+++ b/application/vlc-android/res/layout/mrl_item.xml
@@ -56,10 +56,10 @@
         <androidx.appcompat.widget.AppCompatImageView
                 android:id="@+id/mrl_ctx"
                 android:layout_width="wrap_content"
-                android:layout_height="0dp"
-                android:layout_marginEnd="8dp"
+                android:layout_height="wrap_content"
                 android:background="?attr/selectableItemBackgroundBorderless"
                 android:nextFocusLeft="@+id/selector"
+                android:padding="8dp"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintTop_toTopOf="parent"
diff --git a/application/vlc-android/res/layout/video_list_card.xml b/application/vlc-android/res/layout/video_list_card.xml
index 9e48651d7..0a6cc4dd6 100644
--- a/application/vlc-android/res/layout/video_list_card.xml
+++ b/application/vlc-android/res/layout/video_list_card.xml
@@ -69,9 +69,8 @@
             android:onClick="@{holder::onClick}"
             android:onLongClick="@{holder::onLongClick}"
             android:orientation="horizontal"
-            android:paddingLeft="8dp"
+            android:paddingStart="8dp"
             android:paddingTop="4dp"
-            android:paddingRight="8dp"
             android:paddingBottom="4dp"
             android:clipToPadding="false">
 
@@ -214,6 +213,7 @@
                 android:layout_height="wrap_content"
                 android:background="?attr/selectableItemBackgroundBorderless"
                 android:clickable="true"
+                android:padding="8dp"
                 android:contentDescription="@string/more_actions"
                 android:onClick="@{holder::onMoreClick}"
                 android:scaleType="center"
@@ -246,7 +246,7 @@
                 android:id="@+id/selected_check"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:layout_marginEnd="4dp"
+                android:layout_marginEnd="8dp"
                 android:visibility="@{selected ? View.VISIBLE : View.GONE}"
                 vlc:layout_constraintBottom_toBottomOf="parent"
                 vlc:layout_constraintEnd_toEndOf="parent"



More information about the Android mailing list